Ent - IngestBuilderID, IngestPackageID, IngestSourceID, IngestVulnerabilityID #1329

desmax74 · 2023-09-27T16:32:32Z

Description of the PR

Ent backend

IngestBuilderID, IngestPackageID, IngestSourceID, IngestVulnerabilityID (with bulk) implementations
IngestBuilder, IngestPackage, IngestSource IngestVulnerability removed
changes consistently all of the tests involved

Refers to #1198

Depends on cherry-picking (once merged) the fix in #1330 for having all the tests to work fine.

PR Checklist

All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
All new changes are covered by tests
If GraphQL schema is changed, make generate has been run
If collectsub protobuf has been changed, make proto has been run
All CI checks are passing (tests and formatting)
All dependent PRs have already been merged

mrizzi

@desmax74 thanks.

I've shared a further improvement.
Once accepted my PR into this one, then the same approach should be applied in order to optimize also upsertBuilder and upsertSource

pkg/assembler/backends/ent/backend/package.go

mrizzi

Some further notes.

pkg/assembler/backends/ent/backend/builders.go

pkg/assembler/backends/ent/backend/occurrence.go

mrizzi

Reported some last required changes, mainly to the tests.

pkg/assembler/backends/ent/backend/builders_test.go

pkg/assembler/backends/ent/backend/neighbors_test.go

pkg/assembler/backends/ent/backend/builders_test.go

pkg/assembler/backends/ent/backend/neighbors_test.go

pkg/assembler/backends/ent/backend/package_test.go

pkg/assembler/backends/ent/backend/vulnerability.go

pkg/assembler/backends/ent/backend/vulnerability_test.go

mrizzi

I think it's just the Vulnerability related endpoints that need some further improvements.

pkg/assembler/backends/ent/backend/vulnerability.go

pxp928 · 2023-10-19T11:21:57Z

@mrizzi is this ready to be reviewed again?

mrizzi · 2023-10-19T11:56:06Z

@mrizzi is this ready to be reviewed again?

@desmax74 has everything been addressed? also issues reported in chat?

desmax74 · 2023-10-19T12:04:34Z

@mrizzi Writing tests to cover the new execution branches of upsert functions

mrizzi

I think the new tests are great: they just need to be moved into the already available tests for consistency with other similar "ingest same twice" tests .

There's also a removed filtering by ID that I think should be maintained.

pkg/assembler/backends/ent/backend/builders_test.go

pkg/assembler/backends/ent/backend/package_test.go

pkg/assembler/backends/ent/backend/source_test.go

pkg/assembler/backends/ent/backend/vulnerability.go

pkg/assembler/backends/ent/backend/vulnerability_test.go

Signed-off-by: desmax74 <mdessi@redhat.com>

mrizzi

@desmax74 LGTM 🎉 thanks a lot 👍

…bilityID (#1329) * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - upsertPackageIDDoNothing vs upsertPackageIDIgnore (#1270) * Ent - upsertPackageIDDoNothing vs upsertPackageIDIgnore Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - final upsertPackage implementation Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - upsertPackage: enhanced ID management Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - Packages: subpath query issue (#1330) * Ent - Packages: subpath query issue reproducer Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Packages: subpath query issue fix Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - TestIngestVulnerabilities changes to support ID Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - Node: added SourceName management Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> --------- Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: mrizzi <mrizzi@redhat.com> Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com> Co-authored-by: mrizzi <mrizzi@redhat.com>

…bilityID (guacsec#1329) * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - upsertPackageIDDoNothing vs upsertPackageIDIgnore (guacsec#1270) * Ent - upsertPackageIDDoNothing vs upsertPackageIDIgnore Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - final upsertPackage implementation Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - upsertPackage: enhanced ID management Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - Packages: subpath query issue (guacsec#1330) * Ent - Packages: subpath query issue reproducer Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Packages: subpath query issue fix Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - TestIngestVulnerabilities changes to support ID Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - Node: added SourceName management Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> --------- Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: mrizzi <mrizzi@redhat.com> Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com> Co-authored-by: mrizzi <mrizzi@redhat.com>

…bilityID (guacsec#1329) * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - upsertPackageIDDoNothing vs upsertPackageIDIgnore (guacsec#1270) * Ent - upsertPackageIDDoNothing vs upsertPackageIDIgnore Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - final upsertPackage implementation Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - upsertPackage: enhanced ID management Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - Packages: subpath query issue (guacsec#1330) * Ent - Packages: subpath query issue reproducer Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Packages: subpath query issue fix Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - TestIngestVulnerabilities changes to support ID Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - Node: added SourceName management Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> --------- Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: mrizzi <mrizzi@redhat.com> Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com> Co-authored-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com>

…bilityID (#1329) * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - upsertPackageIDDoNothing vs upsertPackageIDIgnore (#1270) * Ent - upsertPackageIDDoNothing vs upsertPackageIDIgnore Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - final upsertPackage implementation Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - upsertPackage: enhanced ID management Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - Packages: subpath query issue (#1330) * Ent - Packages: subpath query issue reproducer Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Packages: subpath query issue fix Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - TestIngestVulnerabilities changes to support ID Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - Node: added SourceName management Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> --------- Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: mrizzi <mrizzi@redhat.com> Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com> Co-authored-by: mrizzi <mrizzi@redhat.com>

…bilityID (guacsec#1329) * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - upsertPackageIDDoNothing vs upsertPackageIDIgnore (guacsec#1270) * Ent - upsertPackageIDDoNothing vs upsertPackageIDIgnore Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - final upsertPackage implementation Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - upsertPackage: enhanced ID management Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - Packages: subpath query issue (guacsec#1330) * Ent - Packages: subpath query issue reproducer Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Packages: subpath query issue fix Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - TestIngestVulnerabilities changes to support ID Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - Node: added SourceName management Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> --------- Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: mrizzi <mrizzi@redhat.com> Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com> Co-authored-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com>

…bilityID (#1329) * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - upsertPackageIDDoNothing vs upsertPackageIDIgnore (#1270) * Ent - upsertPackageIDDoNothing vs upsertPackageIDIgnore Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - final upsertPackage implementation Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - upsertPackage: enhanced ID management Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - Packages: subpath query issue (#1330) * Ent - Packages: subpath query issue reproducer Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Packages: subpath query issue fix Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - TestIngestVulnerabilities changes to support ID Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - Node: added SourceName management Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> --------- Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: mrizzi <mrizzi@redhat.com> Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com> Co-authored-by: mrizzi <mrizzi@redhat.com>

…bilityID (#1329) * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - upsertPackageIDDoNothing vs upsertPackageIDIgnore (#1270) * Ent - upsertPackageIDDoNothing vs upsertPackageIDIgnore Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - final upsertPackage implementation Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - upsertPackage: enhanced ID management Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - Packages: subpath query issue (#1330) * Ent - Packages: subpath query issue reproducer Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Packages: subpath query issue fix Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - TestIngestVulnerabilities changes to support ID Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - Node: added SourceName management Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> --------- Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: mrizzi <mrizzi@redhat.com> Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com> Co-authored-by: mrizzi <mrizzi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com>

… main) (#1542) * Backend interface - Methods for returning 'string' (#1285) Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * Enable GitHub CI tests (#1296) * Enable GitHub CI tests Signed-off-by: mrizzi <mrizzi@redhat.com> * Mocks backend updated Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca (#1283) * Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Pin postgres image to hash Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * Ent - IngestArtifactID,IngestArtifactIDs implementations (#1300) Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * Ent - IngestBuilderID, IngestPackageID, IngestSourceID, IngestVulnerabilityID (#1329) * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - upsertPackageIDDoNothing vs upsertPackageIDIgnore (#1270) * Ent - upsertPackageIDDoNothing vs upsertPackageIDIgnore Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - final upsertPackage implementation Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - upsertPackage: enhanced ID management Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - Packages: subpath query issue (#1330) * Ent - Packages: subpath query issue reproducer Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Packages: subpath query issue fix Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - TestIngestVulnerabilities changes to support ID Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - Node: added SourceName management Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> --------- Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: mrizzi <mrizzi@redhat.com> Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com> Co-authored-by: mrizzi <mrizzi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * Ent - IngestHasSBOMID (#1470) Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * Ent - ScorecardID (#1469) Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * Ent - PkgEqualsID (#1473) Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * update ent IngestHasSbomID and IngestHasSBOMIDs with the new includes field Signed-off-by: pxp928 <parth.psu@gmail.com> * Feature/1116 arango noun mutation update to return only IDs (#1511) * change artifact mutation to return only ID Signed-off-by: pxp928 <parth.psu@gmail.com> * change builder and license to return only ID during ingestion Signed-off-by: pxp928 <parth.psu@gmail.com> * update package to return flat struct of IDs Signed-off-by: pxp928 <parth.psu@gmail.com> * update source and vulnerability to return mutation ID Signed-off-by: pxp928 <parth.psu@gmail.com> * update ENT for vulnerability and package mutation IDs Signed-off-by: pxp928 <parth.psu@gmail.com> * update ENT for source mutation IDs Signed-off-by: pxp928 <parth.psu@gmail.com> * update tests for arango and ent Signed-off-by: pxp928 <parth.psu@gmail.com> --------- Signed-off-by: pxp928 <parth.psu@gmail.com> * Update all resolvers for Return ID (#1514) * Update resolvers to use ID backend methods Signed-off-by: Jeff Mendoza <jlm@jlm.name> * Remove old methods from backend interface, update pkg/src/vuln resolvers. Signed-off-by: Jeff Mendoza <jlm@jlm.name> --------- Signed-off-by: Jeff Mendoza <jlm@jlm.name> Signed-off-by: pxp928 <parth.psu@gmail.com> * Update keyvalue backend to return ID (#1524) * Update keyvalue backend to return ID Signed-off-by: Jeff Mendoza <jlm@jlm.name> * Lint gosimple Signed-off-by: Jeff Mendoza <jlm@jlm.name> * Regen backend mock Signed-off-by: Jeff Mendoza <jlm@jlm.name> --------- Signed-off-by: Jeff Mendoza <jlm@jlm.name> Signed-off-by: pxp928 <parth.psu@gmail.com> * Feature/1116 arango verb mutation (#1529) Signed-off-by: pxp928 <parth.psu@gmail.com> * Complete Ent Return -ID (#1536) * Updated ent with ID Signed-off-by: Jeff Mendoza <jlm@jlm.name> * Update ent tests for ID. Signed-off-by: Jeff Mendoza <jlm@jlm.name> --------- Signed-off-by: Jeff Mendoza <jlm@jlm.name> Signed-off-by: pxp928 <parth.psu@gmail.com> * change mutations back to original name (#1541) Signed-off-by: pxp928 <parth.psu@gmail.com> * remove branch from ci workflow Signed-off-by: pxp928 <parth.psu@gmail.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: Jeff Mendoza <jlm@jlm.name> Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com> Co-authored-by: Massimiliano Dessì - (Fast Chauffeur) <desmax74@users.noreply.github.com> Co-authored-by: mrizzi <mrizzi@redhat.com> Co-authored-by: Jeff Mendoza <jlm@jlm.name>

pull-request-size bot added the size/L label Sep 27, 2023

desmax74 changed the title ~~1116-return-ID~~ Ent - IngestBuilderID, IngestPackageID, IngestSourceID Sep 28, 2023

desmax74 force-pushed the playground-1116-return-ID branch from 5fd8e7b to 5d2f16f Compare September 28, 2023 08:37

mrizzi mentioned this pull request Sep 28, 2023

Ent - Packages: subpath query issue #1330

Merged

6 tasks

mrizzi reviewed Sep 28, 2023

View reviewed changes

pkg/assembler/backends/ent/backend/package.go Show resolved Hide resolved

desmax74 force-pushed the playground-1116-return-ID branch 5 times, most recently from c4ec3a9 to 663a4db Compare September 28, 2023 16:40

pull-request-size bot added size/XL and removed size/L labels Sep 29, 2023

desmax74 force-pushed the playground-1116-return-ID branch 4 times, most recently from 3c9ac0e to d455d5f Compare September 29, 2023 14:39

mrizzi requested changes Sep 29, 2023

View reviewed changes

pkg/assembler/backends/ent/backend/builders.go Outdated Show resolved Hide resolved

pkg/assembler/backends/ent/backend/occurrence.go Outdated Show resolved Hide resolved

desmax74 force-pushed the playground-1116-return-ID branch 2 times, most recently from 011e124 to 3c01da4 Compare September 29, 2023 17:11

desmax74 marked this pull request as ready for review September 29, 2023 17:30

desmax74 requested a review from mihaimaruseac as a code owner September 29, 2023 17:30

mrizzi requested changes Oct 2, 2023

View reviewed changes

mrizzi changed the title ~~Ent - IngestBuilderID, IngestPackageID, IngestSourceID~~ Ent - IngestBuilderID, IngestPackageID, IngestSourceID, IngestVulnerabilityID Oct 2, 2023

pull-request-size bot added size/L and removed size/XL labels Oct 2, 2023

desmax74 force-pushed the playground-1116-return-ID branch from def4aa9 to 70477b4 Compare October 2, 2023 08:20

desmax74 marked this pull request as draft October 2, 2023 08:33

desmax74 force-pushed the playground-1116-return-ID branch from 240458b to 0bf20e1 Compare October 2, 2023 09:13

pull-request-size bot added size/XL and removed size/L labels Oct 2, 2023

mrizzi requested changes Oct 10, 2023

View reviewed changes

pkg/assembler/backends/ent/backend/vulnerability.go Show resolved Hide resolved

pkg/assembler/backends/ent/backend/vulnerability.go Outdated Show resolved Hide resolved

pkg/assembler/backends/ent/backend/vulnerability.go Outdated Show resolved Hide resolved

desmax74 force-pushed the playground-1116-return-ID branch 7 times, most recently from 9633513 to 2bfbbf4 Compare October 16, 2023 08:14

desmax74 force-pushed the playground-1116-return-ID branch 2 times, most recently from f5b1527 to b61769a Compare October 19, 2023 13:51

mrizzi requested changes Oct 20, 2023

View reviewed changes

desmax74 force-pushed the playground-1116-return-ID branch from b214439 to 4593167 Compare October 20, 2023 10:23

1116-return-ID

f76f910

Signed-off-by: desmax74 <mdessi@redhat.com>

desmax74 force-pushed the playground-1116-return-ID branch from b012988 to f76f910 Compare October 23, 2023 10:12

1116-return-ID

5afa9f4

Signed-off-by: desmax74 <mdessi@redhat.com>

mrizzi approved these changes Oct 31, 2023

View reviewed changes

mihaimaruseac approved these changes Oct 31, 2023

View reviewed changes

pxp928 merged commit 51e917b into guacsec:1116-return-ID Nov 2, 2023
9 checks passed

desmax74 deleted the playground-1116-return-ID branch November 4, 2023 16:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ent - IngestBuilderID, IngestPackageID, IngestSourceID, IngestVulnerabilityID #1329

Ent - IngestBuilderID, IngestPackageID, IngestSourceID, IngestVulnerabilityID #1329

desmax74 commented Sep 27, 2023 •

edited

Loading

mrizzi left a comment

mrizzi left a comment

mrizzi left a comment

mrizzi left a comment

pxp928 commented Oct 19, 2023

mrizzi commented Oct 19, 2023

desmax74 commented Oct 19, 2023 •

edited

Loading

mrizzi left a comment

mrizzi left a comment

Ent - IngestBuilderID, IngestPackageID, IngestSourceID, IngestVulnerabilityID #1329

Ent - IngestBuilderID, IngestPackageID, IngestSourceID, IngestVulnerabilityID #1329

Conversation

desmax74 commented Sep 27, 2023 • edited Loading

Description of the PR

PR Checklist

mrizzi left a comment

Choose a reason for hiding this comment

mrizzi left a comment

Choose a reason for hiding this comment

mrizzi left a comment

Choose a reason for hiding this comment

mrizzi left a comment

Choose a reason for hiding this comment

pxp928 commented Oct 19, 2023

mrizzi commented Oct 19, 2023

desmax74 commented Oct 19, 2023 • edited Loading

mrizzi left a comment

Choose a reason for hiding this comment

mrizzi left a comment

Choose a reason for hiding this comment

desmax74 commented Sep 27, 2023 •

edited

Loading

desmax74 commented Oct 19, 2023 •

edited

Loading