-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca #1283
Merged
kodiakhq
merged 2 commits into
guacsec:main
from
mrizzi:ent-bump-v0.12.4-0.20230918073025
Sep 18, 2023
Merged
Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca #1283
kodiakhq
merged 2 commits into
guacsec:main
from
mrizzi:ent-bump-v0.12.4-0.20230918073025
Sep 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrizzi <mrizzi@redhat.com>
6 tasks
pxp928
reviewed
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this @mrizzi! Could we also pin postgres
image to a hash?
Signed-off-by: mrizzi <mrizzi@redhat.com>
pxp928
approved these changes
Sep 18, 2023
mihaimaruseac
approved these changes
Sep 18, 2023
mrizzi
added a commit
to mrizzi/guac
that referenced
this pull request
Sep 19, 2023
* Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Pin postgres image to hash Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com>
pxp928
pushed a commit
that referenced
this pull request
Sep 20, 2023
* Enable GitHub CI tests Signed-off-by: mrizzi <mrizzi@redhat.com> * Mocks backend updated Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca (#1283) * Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Pin postgres image to hash Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com>
desmax74
pushed a commit
to desmax74/guacsec-guac
that referenced
this pull request
Oct 5, 2023
* Enable GitHub CI tests Signed-off-by: mrizzi <mrizzi@redhat.com> * Mocks backend updated Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca (guacsec#1283) * Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Pin postgres image to hash Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com>
desmax74
pushed a commit
to desmax74/guacsec-guac
that referenced
this pull request
Oct 5, 2023
* Enable GitHub CI tests Signed-off-by: mrizzi <mrizzi@redhat.com> * Mocks backend updated Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca (guacsec#1283) * Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Pin postgres image to hash Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com>
pxp928
pushed a commit
that referenced
this pull request
Nov 16, 2023
* Enable GitHub CI tests Signed-off-by: mrizzi <mrizzi@redhat.com> * Mocks backend updated Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca (#1283) * Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Pin postgres image to hash Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com>
pxp928
pushed a commit
that referenced
this pull request
Nov 21, 2023
* Enable GitHub CI tests Signed-off-by: mrizzi <mrizzi@redhat.com> * Mocks backend updated Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca (#1283) * Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Pin postgres image to hash Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com>
pxp928
pushed a commit
that referenced
this pull request
Nov 30, 2023
* Enable GitHub CI tests Signed-off-by: mrizzi <mrizzi@redhat.com> * Mocks backend updated Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca (#1283) * Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Pin postgres image to hash Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com>
pxp928
pushed a commit
that referenced
this pull request
Nov 30, 2023
* Enable GitHub CI tests Signed-off-by: mrizzi <mrizzi@redhat.com> * Mocks backend updated Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca (#1283) * Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Pin postgres image to hash Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com>
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
… main) (#1542) * Backend interface - Methods for returning 'string' (#1285) Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * Enable GitHub CI tests (#1296) * Enable GitHub CI tests Signed-off-by: mrizzi <mrizzi@redhat.com> * Mocks backend updated Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca (#1283) * Ent - Bump v0.12.4-0.20230918073025-797534a0d1ca Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Pin postgres image to hash Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * Ent - IngestArtifactID,IngestArtifactIDs implementations (#1300) Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * Ent - IngestBuilderID, IngestPackageID, IngestSourceID, IngestVulnerabilityID (#1329) * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - upsertPackageIDDoNothing vs upsertPackageIDIgnore (#1270) * Ent - upsertPackageIDDoNothing vs upsertPackageIDIgnore Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - final upsertPackage implementation Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - upsertPackage: enhanced ID management Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - Packages: subpath query issue (#1330) * Ent - Packages: subpath query issue reproducer Signed-off-by: mrizzi <mrizzi@redhat.com> * Ent - Packages: subpath query issue fix Signed-off-by: mrizzi <mrizzi@redhat.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - TestIngestVulnerabilities changes to support ID Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * Ent - Node: added SourceName management Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> * 1116-return-ID Signed-off-by: desmax74 <mdessi@redhat.com> --------- Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: mrizzi <mrizzi@redhat.com> Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com> Co-authored-by: mrizzi <mrizzi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * Ent - IngestHasSBOMID (#1470) Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * Ent - ScorecardID (#1469) Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * Ent - PkgEqualsID (#1473) Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> * update ent IngestHasSbomID and IngestHasSBOMIDs with the new includes field Signed-off-by: pxp928 <parth.psu@gmail.com> * Feature/1116 arango noun mutation update to return only IDs (#1511) * change artifact mutation to return only ID Signed-off-by: pxp928 <parth.psu@gmail.com> * change builder and license to return only ID during ingestion Signed-off-by: pxp928 <parth.psu@gmail.com> * update package to return flat struct of IDs Signed-off-by: pxp928 <parth.psu@gmail.com> * update source and vulnerability to return mutation ID Signed-off-by: pxp928 <parth.psu@gmail.com> * update ENT for vulnerability and package mutation IDs Signed-off-by: pxp928 <parth.psu@gmail.com> * update ENT for source mutation IDs Signed-off-by: pxp928 <parth.psu@gmail.com> * update tests for arango and ent Signed-off-by: pxp928 <parth.psu@gmail.com> --------- Signed-off-by: pxp928 <parth.psu@gmail.com> * Update all resolvers for Return ID (#1514) * Update resolvers to use ID backend methods Signed-off-by: Jeff Mendoza <jlm@jlm.name> * Remove old methods from backend interface, update pkg/src/vuln resolvers. Signed-off-by: Jeff Mendoza <jlm@jlm.name> --------- Signed-off-by: Jeff Mendoza <jlm@jlm.name> Signed-off-by: pxp928 <parth.psu@gmail.com> * Update keyvalue backend to return ID (#1524) * Update keyvalue backend to return ID Signed-off-by: Jeff Mendoza <jlm@jlm.name> * Lint gosimple Signed-off-by: Jeff Mendoza <jlm@jlm.name> * Regen backend mock Signed-off-by: Jeff Mendoza <jlm@jlm.name> --------- Signed-off-by: Jeff Mendoza <jlm@jlm.name> Signed-off-by: pxp928 <parth.psu@gmail.com> * Feature/1116 arango verb mutation (#1529) Signed-off-by: pxp928 <parth.psu@gmail.com> * Complete Ent Return -ID (#1536) * Updated ent with ID Signed-off-by: Jeff Mendoza <jlm@jlm.name> * Update ent tests for ID. Signed-off-by: Jeff Mendoza <jlm@jlm.name> --------- Signed-off-by: Jeff Mendoza <jlm@jlm.name> Signed-off-by: pxp928 <parth.psu@gmail.com> * change mutations back to original name (#1541) Signed-off-by: pxp928 <parth.psu@gmail.com> * remove branch from ci workflow Signed-off-by: pxp928 <parth.psu@gmail.com> --------- Signed-off-by: mrizzi <mrizzi@redhat.com> Signed-off-by: pxp928 <parth.psu@gmail.com> Signed-off-by: desmax74 <mdessi@redhat.com> Signed-off-by: Jeff Mendoza <jlm@jlm.name> Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com> Co-authored-by: Massimiliano Dessì - (Fast Chauffeur) <desmax74@users.noreply.github.com> Co-authored-by: mrizzi <mrizzi@redhat.com> Co-authored-by: Jeff Mendoza <jlm@jlm.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
@pxp928 reported thet Ent backend tests are failing: https://github.com/guacsec/guac/actions/runs/6203866065/job/16845132555?pr=1280#step:7:40
I figured out that Postresql 16 has been released 2 days ago (Saturday, Sept 16th) so guac's GH Jobs started using it since the GH
postgres
service in the integration tests runspostgres
(latest) image.But Postresql 16 has an issue with Ent (ent/ent#3750) which required a fix in an Ent's library, Ariga/Atlas (ariga/atlas#2094)
Ent's PR for updating Atlas' version has been merged (ent/ent#3751) so upgrading to latest Ent version.
PR Checklist
-s
flag togit commit
.make generate
has been runcollectsub
protobuf has been changed,make proto
has been run