Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TraceMap fails for "not-so-faint" fibers. The relative_threshold requirement does not change the result #273

Open
gildepaz opened this issue Nov 22, 2019 · 2 comments
Open

TraceMap fails for "not-so-faint" fibers. The relative_threshold requirement does not change the result #273

gildepaz opened this issue Nov 22, 2019 · 2 comments
Assignees
@sergiopasra
Labels
enhancement question

Comments

@gildepaz
Copy link
Member

TraceMap fails for "not-so-faint" fibers but the relative_threshold requirement does not change the result. Would it be possible to change the trace.py so it reads the relative_threshold requirement? Thx!
@sergiopasra
Copy link
Member

Yes, relative_threshold is not used. I need a test dataset anyway

@sergiopasra
Copy link
Member

Yes, relative_threshold is not used.

Well, it's a little more complex than that. It is used if and only if there is no predefined value. But there is a value of relative_threshold predefined for all the VPH/INSMODE combination, so the passed value is never used

@sergiopasra sergiopasra self-assigned this May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergiopasra sergiopasra

Labels
enhancement question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sergiopasra @gildepaz