Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #30 #46

Merged
merged 5 commits into from
Nov 18, 2011
Merged

Fix for Issue #30 #46

merged 5 commits into from
Nov 18, 2011

Conversation

pauljamesrussell
Copy link
Contributor

This is a fix for issue #30. I've implemented the following changes as discussed in the issue. Feel free to cherry pick, but please bear in mind that some of the commits are bug fixes on earlier commits (sorry!).

  • Changed the default :wait option to 30 seconds, and updated documentation accordingly.
  • Implemented a 60 second 'grace period' after the wait period has expired.
  • Updated error messages and notifications as appropriate, including telling the user how long it actually took to start spork and recommending updating the :wait option accordingly.
  • Implemented a spec for this behaviour (there was no spec at all originally). Note that coverage is not 100% - I haven't implemented a spec for the retry loop itself, although its implicitly tested to some degree in the success scenarios.
  • Implemented a tweak to the specs to make them run faster by stubbing a 'virtual' sleep method into the runner which does a no-op.

Thanks,

Paul

When a service fails to start in the configured time, it'll wait a further 60 seconds before finally giving up, warning in the meantime.

Added tests as appropriate, although they're not perfect since they don't test the actual retry loop.
…Updated error text.

Now makes sense in the context of the readme.
thibaudgg added a commit that referenced this pull request Nov 18, 2011
@thibaudgg thibaudgg merged commit 8fa2288 into guard:master Nov 18, 2011
@thibaudgg
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants