Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Issue #30 #46

Merged
merged 5 commits into from
Nov 18, 2011
Merged

Fix for Issue #30 #46

merged 5 commits into from
Nov 18, 2011

Commits on Nov 16, 2011

  1. Changed default wait to 30 seconds, added additional explanation to e… 

    …rror message on timeout.
    @pauljamesrussell
    pauljamesrussell committed Nov 16, 2011
    Configuration menu
    Copy the full SHA
    b92ee1e View commit details
    Browse the repository at this point in the history

  2. Updated readme to reflect new default wait.

    @pauljamesrussell
    pauljamesrussell committed Nov 16, 2011
    Configuration menu
    Copy the full SHA
    27ebbce View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2011

  1. Added 60 second 'grace' period to startup process. 

    When a service fails to start in the configured time, it'll wait a further 60 seconds before finally giving up, warning in the meantime.

Added tests as appropriate, although they're not perfect since they don't test the actual retry loop.
    @pauljamesrussell
    pauljamesrussell committed Nov 17, 2011
    Configuration menu
    Copy the full SHA
    b6e144a View commit details
    Browse the repository at this point in the history

  2. Ensured that final 'success' message is displayed once spark starts. … 

    …Updated error text.

Now makes sense in the context of the readme.
    @pauljamesrussell
    pauljamesrussell committed Nov 17, 2011
    Configuration menu
    Copy the full SHA
    e271940 View commit details
    Browse the repository at this point in the history

  3. Time in success message now in whole seconds.

    @pauljamesrussell
    pauljamesrussell committed Nov 17, 2011
    Configuration menu
    Copy the full SHA
    e6f04a9 View commit details
    Browse the repository at this point in the history