refactor: Switch to using an auto-generated riff-raff.yaml file #659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #645.
What does this change?
In this change we move to an auto-generated
riff-raff.yaml
file using @guardian/cdk, a feature released in v47.1.0.Why?
Primarily, this is to test the experimental1 GuCDK feature "in the wild". But also, it simplifies things a little; should we wish to deploy to another region, we'd now just need to update the
cdk.ts
file and the generatedriff-raff.yaml
file will include the new region.Notes
The manual
riff-raff.yaml
explicitly names the CloudFormation stack to deploy to, whereas the auto-generated file opts to use tag discovery (Stack, Stage, and App tags).We need to ensure these tags are present on the CloudFormation stacks before shipping this, else Riff-Raff will try to create a new CFN stack (and fail), which is undesired!Update: Riff-Raff is applying the standard SSA tags to CloudFormation stacks since guardian/riff-raff#934. That is, the aforementioned concern is no longer present.Content of generated file
Footnotes
"Experimental" sounds risky, some background can be found here. The feature is being used in PROD today too. ↩