Add standard tags as part of Cloudformation deployments #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard tags are: App, Stack, Stage (and gu:repo which is already added). When added, existing values are preferred where found. These tags are required by services.gutools.co.uk to group related stacks (those which belong to the same 'App' and 'Stack' but differ by 'Stage'. Many stacks already have these tags, but non-CDK ones may not. Nb. this change will force stack updates for some stacks. This shouldn't be a problem but it may confuse teams without some advance comms.
kenoir
approved these changes
Dec 1, 2022
akash1810
reviewed
Dec 20, 2022
| val defaultTags = Map( | ||
| "Stack" -> target.stack.name, | ||
| "Stage" -> target.parameters.stage.name, | ||
| "App" -> pkg.app.name, |
There was a problem hiding this comment.
I don't think pkg.app.name is the correct value here, as for the stack cmp-monitoring-CODE in the frontend account, it's App tag has value cmp-monitoring-cdk-eu-west-1, suggesting pkg.app.name is the package name. Maybe we should move to making the app deployment property required (currently optional)?
That is, we go from:
stacks: [cmp-monitoring]
allowedStages:
- CODE
- PROD
deployments:
cmp-monitoring-cdk-eu-west-1: # <-- implicit app
regions: [eu-west-1]
type: cloud-formation
contentDirectory: 'cloud-formation'
parameters:
prependStackToCloudFormationStackName: false
cloudFormationStackName: cmp-monitoring
templateStagePaths:
CODE: CmpMonitoringStackEUCode.template.json
PROD: CmpMonitoringStackEUProd.template.json
cloudFormationStackByTags: falseTo:
stacks: [cmp-monitoring]
allowedStages:
- CODE
- PROD
deployments:
cmp-monitoring-cdk-eu-west-1:
app: cmp-monitoring # <-- explicit app
regions: [eu-west-1]
type: cloud-formation
contentDirectory: 'cloud-formation'
parameters:
prependStackToCloudFormationStackName: false
cloudFormationStackName: cmp-monitoring
templateStagePaths:
CODE: CmpMonitoringStackEUCode.template.json
PROD: CmpMonitoringStackEUProd.template.json
cloudFormationStackByTags: false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard tags are: App, Stack, Stage.
These tags are required by services.gutools.co.uk to group related stacks (those which belong to the same 'App' and 'Stack' but differ by 'Stage'.
Many stacks already have these tags, but non-CDK ones may not.
Nb. this change will force stack updates for some stacks. This shouldn't be a problem but it may confuse teams without some advance comms. The plan is to do a joint email covering this and also #927 at the same time.