Adopt GHA-Scala-Library-Release-Workflow #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/guardian/gha-scala-library-release-workflow gives us an automated way to publish releases of this library without needing individual Sonatype credentials for each developer! See also the list of Guardian projects that have adopted this workflow so far: guardian/gha-scala-library-release-workflow#20
rtyley
commented
Jan 16, 2024
Comment on lines
-22
to
-38
| def listJsonFiles(file: File) : List[File] = { | ||
| if(file.isDirectory) { | ||
| file.listFiles().toList.flatMap(listJsonFiles) | ||
| } else { | ||
| List(file) | ||
| } | ||
| } | ||
|
|
||
| def listJsonFilesInJsonDir: List[(File, String)] = { | ||
|
|
||
| val jsonFilesDir = file("json") | ||
| val jsonDir = jsonFilesDir.getAbsoluteFile.toPath.getParent | ||
|
|
||
| listJsonFiles(jsonFilesDir).map { | ||
| file => file -> jsonDir.relativize(file.getAbsoluteFile.toPath).toString | ||
| } | ||
| } |
There was a problem hiding this comment.
These two methods (listJsonFiles() & listJsonFilesInJsonDir()) have been superfluous since PR #65 switched to using the guardian/actions-riff-raff GitHub Action which supports the contentDirectories setting:
cross-platform-navigation/.github/workflows/ci.yml
Lines 55 to 57 in 4edadda
JamieB-gu
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gha-scala-library-release-workflowgives us an automated way to publish releases of this library without needing individual Sonatype credentials for each developer!The configuration changes are all described in the docs for
gha-scala-library-release-workflow.We've also granted access to the release credentials through https://github.com/guardian/github-secret-access/pull/34.
See also the list of Guardian projects that have adopted this workflow so far: guardian/gha-scala-library-release-workflow#20