-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create @guardian/source-development-kitchen
#1459
Conversation
🦋 Changeset detectedLatest commit: 37a9051 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Tip Once this PR is ready to go, add the This saves us a lot of money by not running the tests before we need them. |
Note The following canaries were published to NPM: 🐥 |
Note The following canaries were published to NPM: 🐥 |
279e13c
to
8a07a61
Compare
tested (with #1435) in guardian/dotcom-rendering#11399 |
This reverts commit cee0e57.
Co-authored-by: Oliver Abrahams <ollie.abrahams@guardian.co.uk>
05ddd12
to
760fd32
Compare
Note The following canaries were published to NPM: 🐥 |
What are you changing?
Creates
@guardian/source-development-kitchen
, in a correlate to #1435.Why?
If
foundations
andreact-components
are becoming sections of@guardian/source
, it makes sense to do the same for dev kitchen:Before
After
This leaves us with two decoupled, consistent source packages:
@guardian/source
@guardian/source-development-kitchen
This means they are both then more extensible: they can stay as they are, or accommodate future developments, e.g.: