Try @guardian/source package once more
#1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e215f5b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sndrs
added
the
🐥 Canaries
|
Tip Once this PR is ready to go, add the This saves us a lot of money by not running the tests before we need them. |
|
🐥 |
|
🐥 |
|
🐥 |
|
🐥 |
|
🐥 |
sndrs
removed
the
🐥 Canaries
|
🐥 |
sndrs
force-pushed
the
oa/sndrs/single-source
branch
from
d628280
to
9c84458
Compare
sndrs
changed the title
@guardian/source package once more
sndrs
force-pushed
the
oa/sndrs/single-source
branch
from
4e23cbb
to
6e5e802
Compare
Co-authored-by: Oliver Abrahams <ollie.abrahams@guardian.co.uk>
Co-authored-by: Oliver Abrahams <ollie.abrahams@guardian.co.uk>
Co-authored-by: Oliver Abrahams <ollie.abrahams@guardian.co.uk>
Co-authored-by: Alex Sanders <alex@sndrs.dev>
Co-authored-by: Alex Sanders <alex@sndrs.dev>
Co-authored-by: Alex Sanders <alex@sndrs.dev>
sndrs
force-pushed
the
oa/sndrs/single-source
branch
from
6e5e802
to
e215f5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing?
create a single
@guardian/sourcepackage (again).Warning
This PR does not get rid of the old ones yet. They should still be what people use. This version could go away again pretty quickly.
Why?
managing
peerDepsbetween tightly bound packages is hard, especially when they live in he same repo.ideally you want the code on the disk to be the code that runs i.e. if you change
source-foundationsyou want to see that reflected insource-react-componentswhile developing.but that means keeping the
peerDeprange ofsource-react-componentsin sync with the current version ofsource-foundations.This in turn means releasing a major version of
source-react-componentseverytime there's a new version ofsource-foundations, even if it's a patch.This is the correct thing to do, but it's not desirable.
We concluded that was a smell coming from the package set up. The Source packages are tightly coupled, and the reason they are separate now is because we didn't understand properly how to support the old Node module resolution algorithm with sub-packages. We also didn't know about
peerDependenciesMetalast time we looked at it.Using those, we can create a single Source package that maps:
@guardian/source-foundations→@guardian/source/foundations@guardian/source-react-components→@guardian/source/react-componentsWe can also make React/emotion optional
peerDepsfor people not using the react components.Most package managers will install peerdeps anyway, so the optional flag just ensures that any version a consumer may also install matches the one we need.
Co-authored with @oliverabrahams