Update collections #784
Merged
Update collections #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichieAHB
force-pushed
the
rahb/update-collections
branch
from
3ce97b7
to
7b499f4
Compare
RichieAHB
force-pushed
the
rahb/update-collections
branch
from
7b499f4
to
82ee07b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
We now have a strategy for updating collections based on where we are in the tool - much like previous PRs.
Implementation notes
Have tried to reconcile out types in this PR as some of them had got out of sync with the Editions Postgres PR.
After looking at the Postgres PR again I can see that currently the routes aren't quite correct here and I'll need to do a bit of work in a separate PR to ensure we have enough context to fire of fetches with both the
editionNameandissueId.Checklist
General
Client