Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Non-AWS dependency updates #199

Closed
wants to merge 33 commits into from
Closed

chore(deps): Non-AWS dependency updates #199

wants to merge 33 commits into from

Conversation

gu-scala-steward-public-repos[bot]
Copy link
Contributor

@gu-scala-steward-public-repos gu-scala-steward-public-repos bot commented Jul 25, 2023 •
edited
Loading

About this PR

Updates:

Usage

✅ Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add these to your .scala-steward.conf file to ignore future updates of these dependencies:

updates.ignore = [
  { groupId = "com.google.apis", artifactId = "google-api-services-admin-directory" },
  { groupId = "com.google.auth", artifactId = "google-auth-library-oauth2-http" },
  { groupId = "com.google.guava", artifactId = "guava" },
  { groupId = "com.typesafe.play", artifactId = "play" },
  { groupId = "com.typesafe.play", artifactId = "play" },
  { groupId = "com.typesafe.play", artifactId = "play-test" },
  { groupId = "com.typesafe.play", artifactId = "play-test" },
  { groupId = "com.typesafe.play", artifactId = "play-ws" },
  { groupId = "com.typesafe.play", artifactId = "play-ws" },
  { groupId = "org.scala-lang", artifactId = "scala-library" },
  { groupId = "org.scalatest", artifactId = "scalatest" },
  { groupId = "org.typelevel", artifactId = "cats-core" },
  { groupId = "org.xerial.sbt", artifactId = "sbt-sonatype" }
]

Or, add these to slow down future updates of these dependencies:

dependencyOverrides = [
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.google.apis", artifactId = "google-api-services-admin-directory" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.google.auth", artifactId = "google-auth-library-oauth2-http" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.google.guava", artifactId = "guava" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.typesafe.play", artifactId = "play" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.typesafe.play", artifactId = "play" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.typesafe.play", artifactId = "play-test" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.typesafe.play", artifactId = "play-test" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.typesafe.play", artifactId = "play-ws" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "com.typesafe.play", artifactId = "play-ws" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.scala-lang", artifactId = "scala-library" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.scalatest", artifactId = "scalatest" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.typelevel", artifactId = "cats-core" }
  },
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "org.xerial.sbt", artifactId = "sbt-sonatype" }
  }
]
labels: dependencies, library-update, test-library-update, sbt-plugin-update, early-semver-minor, semver-spec-minor, early-semver-patch, semver-spec-patch, early-semver-major, semver-spec-major, version-scheme:early-semver, commit-count:n:9

@gu-scala-steward-public-repos gu-scala-steward-public-repos bot changed the title Non-AWS dependency updates chore(deps): Non-AWS dependency updates Nov 9, 2023
rtyley added a commit that referenced this pull request Dec 7, 2023
@rtyley
Prevent Scala Steward breaking com.typesafe.play
0014324 
Looking at #199, we can
see that Scala Steward is trying to upgrade Play version numbers in ways
that aren't correct:

https://www.playframework.com/documentation/3.0.x/Migration30#Changed-groupId

This is possibly related to:

scala-steward-org/scala-steward#3191
scala-steward-org/scala-steward#3191 (comment)

To fix this up, for now we'll ignore Play updates here, as in
guardian/play-secret-rotation@607802e
@rtyley rtyley mentioned this pull request Dec 7, 2023
Merged
rtyley
rtyley reviewed Dec 7, 2023
View reviewed changes
project/Dependencies.scala
val V29 = PlayVersion("29", "com.typesafe.play", "2.9.0", supportsScala3 = true)
val V28 = PlayVersion("28", "com.typesafe.play", "2.8.21")
val V29 = PlayVersion("29", "com.typesafe.play", "3.0.0", supportsScala3 = true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upgrade for V29 from 2.9.0 to 3.0.0 is wrong here - we don't want it to jump major versions.

See #206

@rtyley
Copy link
Member

rtyley commented Dec 7, 2023

Closing because the Play V29 upgrade from 2.9.0 to 3.0.0 is wrong - have raised #206, and the next Scala Steward job should hopefully not attempt that particular upgrade.

@rtyley rtyley closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtyley rtyley rtyley left review comments

Assignees
No one assigned
Labels
commit-count:n:8 commit-count:n:9 dependencies early-semver-major early-semver-minor early-semver-patch library-update old-version-remains sbt-plugin-update semver-spec-major semver-spec-minor semver-spec-patch test-library-update version-scheme:early-semver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rtyley