You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.
In some cases, we are exporting Emotion CSS from source-foundations. This goes against the principle that source-foundations should be agnostic as to which css-in-js frameworks it supports.
It also breaks the build for AMP in DCR, because it makes the assumption that some of the CSS we export is not Emotion CSS.
Work done
Original PR that was closed and split into the two below for clarity: #1554
Following some discussion on #1568, we've decided to pause work on this and discuss our approach towards removing the dependency on emotion that we have in source-foundations instead of potentially setting it in stone by adding it as a peer dependency.
Background
In some cases, we are exporting Emotion CSS from source-foundations. This goes against the principle that source-foundations should be agnostic as to which css-in-js frameworks it supports.
It also breaks the build for AMP in DCR, because it makes the assumption that some of the CSS we export is not Emotion CSS.
Work done
Original PR that was closed and split into the two below for clarity:
#1554
The text was updated successfully, but these errors were encountered: