Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

Untangling emotion from source-foundations #1574

Closed
ashishpuliyel opened this issue Oct 7, 2022 · 1 comment · Fixed by #1566, #1592 or #1593
Closed

Untangling emotion from source-foundations #1574

ashishpuliyel opened this issue Oct 7, 2022 · 1 comment · Fixed by #1566, #1592 or #1593
Assignees
Labels
foundations Affects @guardian/source-foundations
Milestone

Comments

@ashishpuliyel
Copy link
Member

ashishpuliyel commented Oct 7, 2022

Background

In some cases, we are exporting Emotion CSS from source-foundations. This goes against the principle that source-foundations should be agnostic as to which css-in-js frameworks it supports.

It also breaks the build for AMP in DCR, because it makes the assumption that some of the CSS we export is not Emotion CSS.

Work done

Original PR that was closed and split into the two below for clarity:
#1554

@ob6160 ob6160 changed the title Fix invalid CSS syntax exported from source-foundations Untangling emotion from source-foundations Oct 7, 2022
@ob6160
Copy link
Contributor

ob6160 commented Oct 7, 2022

Following some discussion on #1568, we've decided to pause work on this and discuss our approach towards removing the dependency on emotion that we have in source-foundations instead of potentially setting it in stone by adding it as a peer dependency.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.