Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

RadioGroup allow supporting prop to be able to use ReactNode #623

Closed
liywjl opened this issue Nov 25, 2020 · 2 comments
Closed

RadioGroup allow supporting prop to be able to use ReactNode #623

liywjl opened this issue Nov 25, 2020 · 2 comments
Assignees
Labels
Radio Changes to the radio button component

Comments

@liywjl
Copy link
Contributor

liywjl commented Nov 25, 2020

Is your feature request related to a problem? Please describe.

In some quizzes on frontend we have a supporting image next to the question (example: https://www.theguardian.com/football/that-1980s-sports-blog/2020/jun/12/sports-quiz-football-in-the-1980s look at question 4).

The best way to render the supporting image would be as part of the RadioGroup component. However there is no way to have text followed by supporting media in the current design.

Describe the solution you'd like

We could change supporting prop on RadioGroup to allow text | ReactNode allowing us to have images or videos as supporting content.

Describe alternatives you've considered

  • We could add another prop (suggestion: supportingMedia as a name) to RadioGroup
  • We could allow RadioGroup to allows other components other than Radio (not ideal)
@SiAdcock SiAdcock added the Radio Changes to the radio button component label Nov 27, 2020
@SiAdcock
Copy link
Contributor

Hi @liywjl, thanks for requesting this. We'd be totally up for supporting it. Would you be able to raise a PR?

@SiAdcock
Copy link
Contributor

SiAdcock commented Jul 8, 2021

Fixed in #839

@SiAdcock SiAdcock closed this as completed Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Radio Changes to the radio button component
Projects
None yet
Development

No branches or pull requests

3 participants