-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2705 appimage script #3011
Merged
mssalvatore
merged 5 commits into
2705-upgrade-island-python-version
from
2705-appimage-script
Feb 27, 2023
Merged
2705 appimage script #3011
mssalvatore
merged 5 commits into
2705-upgrade-island-python-version
from
2705-appimage-script
Feb 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssalvatore
requested changes
Feb 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cakekoa
force-pushed
the
2705-appimage-script
branch
from
February 27, 2023 17:10
27b0a1a
to
3c75397
Compare
Switch from using `pipenv sync --system` to using the requirements file generated from `pipenv requirements`. The `pipenv sync --system` command (added in #1993) does not work in newer versions of pipenv. It uses the python version of the system rather than the one specified by the --python flag. The `pipenv requirements` command has been added that only pulls from the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed to only dump out requirements for the appropriate system (see pypa/pipenv#5092).
cakekoa
force-pushed
the
2705-appimage-script
branch
from
February 27, 2023 17:13
3c75397
to
c75bacc
Compare
mssalvatore
approved these changes
Feb 27, 2023
mssalvatore
added a commit
that referenced
this pull request
Feb 27, 2023
mssalvatore
added a commit
that referenced
this pull request
Feb 28, 2023
mssalvatore
added a commit
that referenced
this pull request
Mar 1, 2023
mssalvatore
added a commit
that referenced
this pull request
Mar 1, 2023
mssalvatore
added a commit
that referenced
this pull request
Mar 1, 2023
mssalvatore
added a commit
that referenced
this pull request
Mar 1, 2023
VakarisZ
added a commit
that referenced
this pull request
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of #2705.
Updates the app image script to
PR Checklist
Testing Checklist