Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2705 appimage script #3011

Merged
merged 5 commits into from
Feb 27, 2023

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Feb 27, 2023

What does this PR do?

Fixes part of #2705.

Updates the app image script to

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Copy link
Collaborator

@mssalvatore mssalvatore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Export TCl/Tk
export TCL_LIBRARY="${APPDIR}/usr/share/tcltk/tcl8.4"
export TK_LIBRARY="${APPDIR}/usr/share/tcltk/tk8.4"
export TKPATH="${TK_LIBRARY}"

These lines may no longer be needed in AppRun. They appear in the 3.7 appimage's AppRun but not 3.11.
image

Switch from using `pipenv sync --system` to using the requirements file
generated from `pipenv requirements`.

The `pipenv sync --system` command (added in #1993)  does not work in
newer versions of pipenv. It uses the python version of the system
rather than the one specified by the --python flag.

The `pipenv requirements` command has been added that only pulls from
the Pipfile.lock file (pypa/pipenv#4959, pypa/pipenv#5200), and fixed
to only dump out requirements for the appropriate system
(see pypa/pipenv#5092).
@cakekoa cakekoa marked this pull request as ready for review February 27, 2023 17:25
@mssalvatore mssalvatore merged commit a8e86f4 into 2705-upgrade-island-python-version Feb 27, 2023
@mssalvatore mssalvatore deleted the 2705-appimage-script branch February 27, 2023 17:27
mssalvatore added a commit that referenced this pull request Mar 1, 2023
mssalvatore added a commit that referenced this pull request Mar 1, 2023
mssalvatore added a commit that referenced this pull request Mar 1, 2023
mssalvatore added a commit that referenced this pull request Mar 1, 2023
VakarisZ added a commit that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants