Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

Implement Unix file descriptor passing #1

Closed
guelfey opened this issue Jan 25, 2013 · 2 comments
Closed

Implement Unix file descriptor passing #1

guelfey opened this issue Jan 25, 2013 · 2 comments
Assignees

Comments

@guelfey
Copy link
Owner

guelfey commented Jan 25, 2013

Neither the authentication, nor the marshalling code currently support the passing of unix file descriptors.

@ghost ghost assigned guelfey Jan 25, 2013
@guelfey
Copy link
Owner Author

guelfey commented Feb 7, 2013

Plan of attack:

  1. Add support for the Unix file descriptor type in proto.go and message.go, creating type UnixFD int32.
  2. Define a transport interface that is used instead of a net.Conn, which will also help to fix Support transports besides unix #6. This interface then defines methods like SendMessage and ReadMessage, which could handle things like file descriptor passing. Also, the method SupportsUnixFDs (returning a bool) should be defined.
  3. Implement this interface for the unix transport, including file descriptor passing.
  4. Modify Connection to work with this new interface:
    • Send a NEGOTIATE_UNIX_FD in the auth protocol if the transport supports it.
    • Track whether unix fds are supported for the connection (new struct member). (Add a method that returns this value?)
    • Reject messages containing Unix fds if they're not supported.

@guelfey
Copy link
Owner Author

guelfey commented Feb 23, 2013

Fixed by 299651a.

@guelfey guelfey closed this as completed Feb 23, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant