Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Light color theme #13

Closed
10 tasks done
Guerra24 opened this issue Jan 18, 2019 · 2 comments
Closed
10 tasks done

Implement Light color theme #13

Guerra24 opened this issue Jan 18, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@Guerra24
Copy link
Owner

Guerra24 commented Jan 18, 2019 •
edited
Loading

This requires separating the color rules into a light.css and dark.css files, something like this:

  • tags-dark.css
  • tags-light.css
  • base-dark.css
  • base-light.css
  • context-dark.css
  • context-light.css
  • pagesContent-dark.css
  • pagesContent-light.css
  • pagesChrome-dark.css
  • pagesChrome-light.css

Only color rules will be separated. Also needs special handling for the scrollbars and forced tooltips.

The Light theme will be based on the 19H1's colors and only target Firefox 65+ due to more compatibility with Nightly's rules.
@Guerra24 Guerra24 added enhancement New feature or request nightly Nightly bugs that may or may not happen in stable firefox-65 labels Jan 18, 2019
Guerra24 added a commit that referenced this issue Feb 7, 2019
@Guerra24
Working Light Theme #13
34de97b
@maicol07
Copy link

Waiting this! 👍🏻

@Guerra24
Copy link
Owner Author

Light theme has been available for a while but is not 100% finished due to dev toolbox being a pain to work with. Made some changes in the latest commit that fixes color issues. I will keep this open until it is properly finished, no ETA for that but feel free to report any issues.

// @maicol07

@Guerra24 Guerra24 removed the nightly Nightly bugs that may or may not happen in stable label Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Guerra24 @maicol07