Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown: Subfolder heading level is wrong #5

Closed
drodil opened this issue Feb 11, 2022 · 2 comments
Closed

Markdown: Subfolder heading level is wrong #5

drodil opened this issue Feb 11, 2022 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@drodil
Copy link

drodil commented Feb 11, 2022

When adding sub folders to the yaml file the markdown heading level should increase

For example

label: My Bookmarks
description: Collection of my bookmarks
folders:
  - label: General
     folders:
        - label: Search engines
          bookmarks:
            - label: Google
               href: https://www.google.com

Should render as

# My bookmarks

Collection of my bookmarks

## General

### Search engines

* [Google](https://www.google.com)

Currently it renders as:

# My bookmarks

Collection of my bookmarks

## General

## Search engines

* [Google](https://www.google.com)
@robinglen robinglen added bug Something isn't working good first issue Good for newcomers labels Feb 11, 2022
@robinglen
Copy link
Collaborator

Hello, thanks for the feedback, like your issue here:
#6

Could you describe what it actually looks like?
I put a note here: https://github.com/thearegee/bookworms/blob/2c724d03f40451fc2289fbf29291808693a1d463/src/generate-bookmarks.js#L44

Markdown has a couple of issues with generating the hierarchy - I want to look into these but would be a great issue for you to pick up if interested?

@robinglen
Copy link
Collaborator

This was all solved by @drodil thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants