Fix: Ensure API can be used without an options object (closes #1)

gulpjs · Dec 28, 2018 · 4e39fc8 · 4e39fc8
1 parent 18a2bba
commit 4e39fc8
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/lib/findup-sync.js b/lib/findup-sync.js
@@ -21,7 +21,7 @@ module.exports = function(patterns, options) {
   if (!Array.isArray(patterns)) { patterns = [patterns]; }
   // Create globOptions so that it can be modified without mutating the
   // original object.
-  var globOptions = Object.create(options);
+  var globOptions = Object.create(options || {});
   globOptions.maxDepth = 1;
   globOptions.cwd = path.resolve(globOptions.cwd);
 

diff --git a/test/findup-sync_test.js b/test/findup-sync_test.js
@@ -12,7 +12,11 @@ var rel = function(abspath) {
 
 exports['findup'] = {
   setUp: function(done) {
-    // setup here
+    this.cwd = process.cwd();
+    done();
+  },
+  tearDown: function(done) {
+    process.chdir(this.cwd);
     done();
   },
   'simple': function(test) {
@@ -28,4 +32,17 @@ exports['findup'] = {
     test.equal(findup('not-gonna-exist-i-hope.txt', opts), null, 'should returning null if no files found');
     test.done();
   },
+  'cwd': function(test) {
+    test.expect(8);
+    process.chdir('test/fixtures/a/b');
+    test.equal(rel(findup('foo.txt')), '../foo.txt', 'should find files');
+    test.equal(rel(findup('bar.txt')), 'bar.txt', 'should find files');
+    test.equal(rel(findup('a.txt')), '../../a.txt', 'should find files');
+    test.equal(rel(findup('?.txt')), '../../a.txt', 'should support glob patterns');
+    test.equal(rel(findup('*.txt')), 'bar.txt', 'should find the first thing that matches the glob pattern');
+    test.equal(rel(findup(['b*.txt', 'f*.txt'])), 'bar.txt', 'should find the first thing that matches any of the glob patterns');
+    test.equal(rel(findup(['f*.txt', 'b*.txt'])), 'bar.txt', 'should find the first thing that matches any of the glob patterns');
+    test.equal(findup('not-gonna-exist-i-hope.txt'), null, 'should returning null if no files found');
+    test.done();
+  },
 };