Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated dependencies according to npm audit #31

Closed
wants to merge 1 commit into from

Conversation

bt-nia
Copy link

@bt-nia bt-nia commented Jan 26, 2021

fixes #30 (NOT the Snyk reported issue!)

➜  glob-parent git:(master) ✗ npm test

> glob-parent@5.1.1 pretest /private/tmp/glob-parent
> npm run lint


> glob-parent@5.1.1 lint /private/tmp/glob-parent
> eslint .


> glob-parent@5.1.1 test /private/tmp/glob-parent
> nyc mocha --async-only



  glob-parent
    ✓ should strip glob magic to return parent path
    ✓ should respect escaped characters
    ✓ should respect glob enclosures with embedded separators
    ✓ should handle nested braces
    ✓ should return parent dirname from non-glob paths
    ✓ should respect disabled auto flip backslashes

  glob2base test patterns
    ✓ should get a base name
    ✓ should get a base name from a nested glob
    ✓ should get a base name from a flat file
    ✓ should get a base name from character class pattern
    ✓ should get a base name from brace , expansion
    ✓ should get a base name from brace .. expansion
    ✓ should get a base name from extglob
    ✓ should get a base name from a path with non-exglob parens
    ✓ should get a base name from a complex brace glob


  15 passing (10ms)

----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
----------|---------|----------|---------|---------|-------------------
All files |   94.44 |    77.78 |     100 |   94.44 |
 index.js |   94.44 |    77.78 |     100 |   94.44 | 23
----------|---------|----------|---------|---------|-------------------

@phated
Copy link
Member

phated commented Jan 26, 2021

In v15, node 8 is required. This package currently supports node 6+; however, the gulp team will be updating the repository template, which drops node support for node <10 and updates nyc to this version.

As this is a devDep, you don't have to worry about this npm audit in your project, as devDeps aren't installed or used in your own deps.

@phated phated closed this Jan 26, 2021
@paulmillr
Copy link
Contributor

@phated maybe drop node <12? node 10 eol is april 2021

@phated
Copy link
Member

phated commented Jan 26, 2021

@paulmillr as I've said before, just because node core EoLs stuff at a ridiculous pace, doesn't mean I plan to leave users high-and-dry like some other prominent maintainers. We will, however, be more brisk in releasing new stuff, now that we have tooling in place to do repo upgrades, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

security risk
3 participants