end event never called ?

[adrienkohlbecker]

Hello,

First, thanks to all contributors for this awesome project.

I'm trying to understand why the callback never gets called in the following example:

var gulp = require('gulp');
gulp.task('mytask', function(cb) {

  callSomeAsyncFunction(function() {

    gulp.src(['./somefile.js'])
      .on('end', cb); // cb never called

  });

});

Here is the output

➜  gulp mytask
[22:08:25] Using gulpfile ~/project/Gulpfile.js
[22:08:25] Starting 'mytask'...
➜ 

[adrienkohlbecker]

Here is an even simpler example case, without the asynchronous function:

var gulp = require('gulp');
gulp.task('mytask', function(cb) {
    gulp.src(['./somefile.js'])
      .on('end', cb); // cb never called
  });
});

Does not work with Gulp 3.8.11 & latest 4.0 branch

[adrienkohlbecker]

It does work when I add a return in the second example, but I can't do that in the asynchronous case.

[phated]

You aren't sinking your stream. If you don't pipe a readable stream to another stream that actually reads from it, it does nothing. We sink the stream for you when you return it.

[callumacrae]

Check out readable.resume() and surrounding docs: this has bitten me before, too!

[adrienkohlbecker]

Thanks both of you! I'll check it out