Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lastRun should return undefined on first run #26

Closed
fabpopa opened this issue Jun 7, 2015 · 2 comments
Closed

lastRun should return undefined on first run #26

fabpopa opened this issue Jun 7, 2015 · 2 comments

Comments

@fabpopa
Copy link
Contributor

fabpopa commented Jun 7, 2015

Hi, I think I'm seeing an issue with Gulp 4.0 after the dependency for undertaker was bumped from ^0.7.0 to ^0.11.0 a week ago. My tasks using lastRun aren't building, since

gulp.task('build:scripts', function() {
  console.log(gulp.lastRun('build:scripts'));    // this outputs the timestamp on first run, not undefined
  return gulp.src('app/**/*.js', { since: gulp.lastRun('build:scripts') })
    .pipe(gulp.dest('dist/app'));
});

outputs the timestamp even on first run, so no change is registered in the files.
Is this just me? Thank you.

@phated
Copy link
Member

phated commented Jun 8, 2015

Can you write a failing test for this and submit as a PR? The current tests are all passing.

@phated
Copy link
Member

phated commented Jun 12, 2015

Fixed by 96540e3

@phated phated closed this as completed Jun 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants