Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility issues from preloading images #32

Open
edrpls opened this issue Nov 21, 2019 · 1 comment
Open

Fix compatibility issues from preloading images #32

edrpls opened this issue Nov 21, 2019 · 1 comment
Milestone

Comments

@edrpls
Copy link

edrpls commented Nov 21, 2019

#31 introduced a possible problem when loading the module as CJS or ESM, since the browser version checks for DOM nodes to get the root URL where the script is loaded from.

@edrpls
Copy link
Author

edrpls commented Jul 22, 2021

FYI, I now believe that said root URL validation is unnecessary. A user loading ggezvp more than once is probably a small edge-case we should not care about.

@edrpls edrpls added this to the 2.0.0 milestone Aug 4, 2021
This was referenced Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant