Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transpilation not working #88

Closed
edrpls opened this issue Jul 8, 2020 · 1 comment
Closed

Transpilation not working #88

edrpls opened this issue Jul 8, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@edrpls
Copy link

edrpls commented Jul 8, 2020

Transpilation is not working, at least for dependencies. This breaks support for Internet Explorer (11, 10)

To Reproduce
Try playing a VAST source in IE or inspect the live code.

Expected behavior
Modern features should be transpiled and polyfilled to ES5 for older browser support.

Screenshots
If applicable, add screenshots to help explain your problem.
image
image

Desktop (please complete the following information):

  • OS: Any with older browsers
  • Browser: IE
  • Version: 10, 11

Additional context
I haven't verified that all of our code is not being transpiled, it could just be our dependencies (VAST-Parser, nano-events)
@edrpls edrpls added the bug Something isn't working label Jul 8, 2020
@edrpls edrpls mentioned this issue Aug 19, 2020
Merged
@edrpls
Copy link
Author

edrpls commented Aug 24, 2020 •
edited
Loading

Fixed by #91 and released on 1.9.0

@edrpls edrpls closed this as completed Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edrpls