-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formal definition of edit script language #38
Comments
Hi Christopher, Thanks for the feedback. It is highly possible that the edit script serializer is not entirely correct w.r.t. to node ids or positions because it has not been tested extensively. Normally the edit script is formalized in our ASE paper you can read it to better understand. Maybe if you have a (small) case with a problem, you can attach the files here and I will take a look at it. |
I'll put together a few unit tests today on my fork to test whether the output matches what I'm expecting, then I'll add a short description here, together with a quick definition of the edit operations, based on the ASE paper. |
I ended up finding a slightly simpler way around the problem (in theory). I just need to use the mappings to work out the IDs of the nodes of interest in P and P', and from there I can do all kinds of clever analyses (some of which use the mappings to simplify things). I recall seeing that someone else had modified GumTree to return the mappings, in addition to the edit script. I don't suppose you know the simplest way I might go about doing that? |
Accepting this pull request would add the functionality required to fix these problems (in a pre-processing stage): #21 |
Please can you provide a more formal definition of the edit script operations and their encodings (with respect to any action serialiser), similar to the (incredibly useful) language definition for DUL. In particular, please could you clarify the node numberings used in the edit script operations, and if/how the order of operations affect the result?
At present time, it looks as if the output for certain operations is inconsistent, but without a clear, formal definition of the language, I can't be sure (and I can't use GumTree for my research until that point).
The text was updated successfully, but these errors were encountered: