Refactor entitycontrollers #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 18, 2018 14:48
Rename AiController to BehaviorController. An IEntity now returns an IEntityAnimationController instead of just an IAnimationController. Implement a method that scales the sprite for an entity via AffineTransform. This method automatically translates the scaled sprite so that it will be scaled around the center of the entity.
There was no actual external value of providing a wildcard type that inherited from IEntity because the consumers wouldn't know what the type actually was anyway. The generic implementation is useful syntax sugar though for actual controller implementations because they might rely on some logic that is determined by a custom Entity implementation. Move the EntityControllerManager from litiengine.entities.ai to litiengine.entities namespace. Introduce a new IEntityProvider interface that marks implementations that provide a related entity.
The Game no longer holds a static EntityControllerManager. Instead, every Entity gets a new EntityControllers object that manages the controllers for the instance. The implementation has been done in such a generic way that it can be used similar to a component system. There are three known default types of controllers in the IEntityAnimationController, IBehaviorController and IMovementController. The default IAnimationController interface is a bit more general and doesn't require any entity. Only controllers that are related to an entity are managed this way. Developers can reuse the new logic to define instances of the known types, define custom ones or overwrite preset instances. The environment will automatically call the controllers attach/detach methods as entities get loaded to or unloaded from the environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously, the whole management of controllers that are related to entities was really inconsistent.
They were also managed globally, although an entity instance always had to be present in order to retrieve them. There were also some issues with the
EntityControllerManagerreturning wildcard types whilst this essentially added no value.The basic interfaces for the controllers were all generic as well which required such an implementation.
Goal
Make the basic controller interfaces non-generic while keeping the syntactic sugar to have a generic implementation for the actual classes.
With this change, the controllers are managed similar to a component-based system and can be directly used/set/retrieved from an entity.
Also, this refactoring adds a method that allows to simply scale the sprite for an entity with a simple method on the IEntityAnimationController.