Implement MapObjectSerializer #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation uses the TmxProperty annotation and reflection to determine which fields of the IEntity implementation need to be serialized to a custom property of the MapObject. Replaced the CustomMapObjectProperty annotation by the TmxProperty annotation. This new annotation is defined on the actual field which is more practical. Also this annotation directly links the field to a key value for custom properties. Previously this was a very loose connection and one had to know the related field. Annotated all currently implemented custom properties for the engine's default entity types with the TmxProperty annotation. This will also allow to further automate the MapObjectLoaders in the long run. Implement a unit test that ensures that the MapObjectSerializer works properly. Rename some MapObjectProperty constants to better reflect their use case. Closes #66
|
Don't know why this build fails at that one test on the pr build only. The push build works without any issue and also locally the tests can be executed without any issue. Guess I'll merge and see if the issue still occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation uses the TmxProperty annotation and reflection to determine which fields of the IEntity implementation need to be serialized to a custom property of the MapObject.
Replaced the CustomMapObjectProperty annotation by the TmxProperty annotation. This new annotation is defined on the actual field which is more practical.
Also this annotation directly links the field to a key value for custom properties. Previously this was a very loose connection and one had to know the related field.
Annotated all currently implemented custom properties for the engine's default entity types with the TmxProperty annotation.
This will also allow to further automate the MapObjectLoaders in the long run.
Implement a unit test that ensures that the MapObjectSerializer works properly.
Rename some MapObjectProperty constants to better reflect their use case.
Closes #66