Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getIntersection() to handle multiple intersections #281

Merged
merged 1 commit into from Jul 1, 2019
Merged

Update getIntersection() to handle multiple intersections #281

merged 1 commit into from Jul 1, 2019

Conversation

CalvinMT
Copy link
Contributor

@CalvinMT CalvinMT commented Jul 1, 2019

  • "getIntersection()" now returns a Rectangle2D representing the union of intersections between the targeted position and all collision boxes that the entity would be colliding with at that targeted position.
  • Add tests in CollisionResolvingTests.java for multiple intersections when moving.

@CalvinMT
Update getIntersection() to handle multiple intersections
e043ae5 
- "getIntersection()" now returns a Rectangle2D representing the union of intersections between the targeted position and all collision boxes that the entity would be colliding with at that targeted position.
- Add tests in CollisionResolvingTests.java for multiple intersections when moving.
@steffen-wilke steffen-wilke self-requested a review July 1, 2019 19:19
steffen-wilke
steffen-wilke reviewed Jul 1, 2019
View reviewed changes
Copy link
Contributor

@steffen-wilke steffen-wilke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! I tested the updated physics with a few game examples and everything works fine. I think this also prevents some weird physics glitches that were related to velocity and collision boxes that were placed closely together.

@steffen-wilke steffen-wilke merged commit 0c66bb3 into gurkenlabs:master Jul 1, 2019
@steffen-wilke steffen-wilke mentioned this pull request Jul 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffen-wilke steffen-wilke steffen-wilke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CalvinMT @steffen-wilke