Input and movement #355
Merged
Input and movement #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vement. - Decelerate to 0 in one tick if the deceleration is set to 0ms instead of decelerating by the tick velocity. - Extend the EntityMovedEvent by the distance property. - Revamp the public API of the MovementController.
Having separate loops in the engine always caused synchronization issues between the threads especially when dispatching input events into game logic performed on the "normal" game loop (e.g. MovementControllers). With this change, the input devices as well as the sound engine are being updated by the usual GameLoop. Custom implementations that previously relied on the input loop as a mean to run independently from the "normal" game loop can now be implemented using an own UpdateLoop instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use proper trigonometry to calculate velocity and angle for entity movement.
Fixes #354
Merge the InputLoop with the GameLoop
Having separate loops in the engine always caused synchronization issues between the threads especially when dispatching input events into game logic performed on the "normal" game loop (e.g. MovementControllers).
With this change, the input devices, as well as the sound engine, are being updated by the usual GameLoop.
Custom implementations that previously relied on the input loop as a means to run independently from the "normal" game loop can now be implemented using an own UpdateLoop instance.