Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deadlock in StatusBar.class #378

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Fix deadlock in StatusBar.class #378

merged 1 commit into from
Mar 15, 2021

Conversation

Gamebuster19901
Copy link
Contributor

@Gamebuster19901 Gamebuster19901 commented Mar 3, 2021 •
edited
Loading

Fixes #350, Fixes #374

@Gamebuster19901 Gamebuster19901 marked this pull request as ready for review March 3, 2021 00:09
@Gamebuster19901 Gamebuster19901 marked this pull request as draft March 3, 2021 00:09
@Gamebuster19901
Copy link
Contributor Author

Ready for review(s), tested and confirmed the deadlock no longer occurs.

I was wrong about the other issues I mentioned in #375 because those components are already being modified on the AWT thread.

@steffen-wilke
@nightm4re94
@weisJ

@Gamebuster19901 Gamebuster19901 marked this pull request as ready for review March 3, 2021 00:22
weisJ
weisJ approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@weisJ weisJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Though if StatusBar#update grows in the amount of changes it does, an approach which supports coalescing update requests may be worthwhile considering.

nightm4re94
nightm4re94 approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@nightm4re94 nightm4re94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much 😊

@nightm4re94 nightm4re94 merged commit 2b9e944 into gurkenlabs:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightm4re94 nightm4re94 nightm4re94 approved these changes

@weisJ weisJ weisJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deadlocks in utiliti Tile map not loading
3 participants
@Gamebuster19901 @nightm4re94 @weisJ