Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partition test cases #382

Merged
merged 21 commits into from
Mar 16, 2021
Merged

Conversation

ddreimane
Copy link
Contributor

Adding partition testing cases to existing tests and creating new tests. Creating new files for testing like:
GameRandomTests.java, EntityDistanceComparatorTests.java , NumberAdjusterTests.java etc.

@jluech
Copy link
Contributor

jluech commented Mar 16, 2021

also added a fix to throw an exception in case of division by zero, see this commit

Copy link
Member

@nightm4re94 nightm4re94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot!
Please address my comments before I can merge this PR.

@nightm4re94 nightm4re94 merged commit 54c2813 into gurkenlabs:master Mar 16, 2021
@Gamebuster19901
Copy link
Contributor

Gamebuster19901 commented May 2, 2021

This package declaration is not correct:

@Gamebuster19901
Copy link
Contributor

Why is the build succeeding if the declared package is incorrect, and AlphanumComparatorTests is missing an import?

8b95505 83c837d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants