Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overall test improvements #390

Merged
merged 19 commits into from
Apr 28, 2021

Conversation

ddreimane
Copy link
Contributor

Overall test improvement of the system.

Copy link
Contributor

@Gamebuster19901 Gamebuster19901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the following build error:

gamebuster@gamebuster-System-Product-Name:~/Desktop/Modding/LitiEngine$ ./gradlew build

> Task :compileTestJava FAILED
/home/gamebuster/Desktop/Modding/LitiEngine/tests/de/gurkenlabs/litiengine/GameRandomTests.java:130: error: cannot find symbol
        Collection<Integer> collection = List.of();
                                             ^
  symbol:   method of()
  location: interface List
1 error

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileTestJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 1s
6 actionable tasks: 4 executed, 2 up-to-date

tests/de/gurkenlabs/litiengine/GameRandomTests.java Outdated Show resolved Hide resolved
Copy link
Member

@nightm4re94 nightm4re94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! With the most recent changes to the PropTests, there is now a merge conflict. Please address that before I can merge.

@jluech
Copy link
Contributor

jluech commented Apr 28, 2021

@nightm4re94 added a small cleanup and force pushed to rebase against current master

Copy link
Member

@nightm4re94 nightm4re94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate your efforts, thanks a ton!

@nightm4re94 nightm4re94 merged commit fdd635e into gurkenlabs:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants