-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve issue from PR #397 and overall improve tests #403
Resolve issue from PR #397 and overall improve tests #403
Conversation
Is that an issue we should fix or is it a configuration error on your side? |
My bad! We migrated our build pipeline from travis to GitHub actions this weekend. Need to exclude the sonar scan for builds outside the main repo again. |
any news on that? |
I've added a condition on the master branch that skips sonar scans in forks. please try merging and we'll see if it works as intended :) |
I triggered a rerun of the checks, now "Gradle SonarQube Scan" is skipped as intended and all checks pass. I cannot merge without write access to the main repository though ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry it took me this long to review. We're very grateful for your work, thank you!
shapeIntersects()
method,Line2D
(a line does not have a geometric area),