Resolve issue from PR #397 and overall improve tests

[jluech]

• Resolved issue from PR #397:
  • added extensive tests for shapeIntersects() method,
  • added different behavior for Line2D (a line does not have a geometric area),
  • switch methods to agreed solution mentioned in comments
• Overall improved tests and increased coverage

[jluech]

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':sonarqube'.
> You're not authorized to run analysis. Please contact the project administrator.

Is that an issue we should fix or is it a configuration error on your side?

[nightm4re94]

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':sonarqube'.
> You're not authorized to run analysis. Please contact the project administrator.

Is that an issue we should fix or is it a configuration error on your side?

My bad! We migrated our build pipeline from travis to GitHub actions this weekend. Need to exclude the sonar scan for builds outside the main repo again.

[jluech]

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':sonarqube'.
> You're not authorized to run analysis. Please contact the project administrator.

Is that an issue we should fix or is it a configuration error on your side?

My bad! We migrated our build pipeline from travis to GitHub actions this weekend. Need to exclude the sonar scan for builds outside the main repo again.

any news on that?

[nightm4re94]

I've added a condition on the master branch that skips sonar scans in forks. please try merging and we'll see if it works as intended :)

[jluech]

I triggered a rerun of the checks, now "Gradle SonarQube Scan" is skipped as intended and all checks pass.
EDIT: at least here in the PR. In my fork repository, however, the master branch now also includes your change yet it starts the Java 8 build which will still fail on the sonarqube step with above error message...

I cannot merge without write access to the main repository though ;)

[nightm4re94]

I'm sorry it took me this long to review. We're very grateful for your work, thank you!