Improve AssetPanelItem #420
Conversation
- Aligned asset name to center - Made sure the buttonPanel is always the same size - When asset name is to large, the buttonPanel will be shown on top - Made clicking the AssetPanelItem easier
| textField.setLineWrap(true); | ||
| textField.setColumns(10); | ||
| SimpleAttributeSet attributes = new SimpleAttributeSet(); | ||
| StyleConstants.setAlignment(attributes, StyleConstants.ALIGN_CENTER); |
There was a problem hiding this comment.
| StyleConstants.setAlignment(attributes, StyleConstants.ALIGN_CENTER); | |
| StyleConstants.setAlignment(attributes, StyleConstants.ALIGN_JUSTIFIED); |
I'd prefer justified alignment over centered text. The last line of multiline text should not be centered in my opinion.
There was a problem hiding this comment.
Using justify will more or less look exaclty the same as the not aligned text before.
I'll remove the alignment and go back to a JTextArea, which is easier to use without the alignment styling.
I'll keep the 2 lines and button size changes.
There was a problem hiding this comment.
This won't center the text if it is a single line, which is still desirable in my opinion. Though I generally dislike the idea of using a JTextPane to display the filename as it is quite heavy. Maybe we can use a JLabel with html content and have the rename action sit inside a context menu with a separate popup?
There was a problem hiding this comment.
I changed the alignment back to before (left) and went back to a JTextArea instead of the JTextPane.
To keep the longer names more visible, I kept the following behaviour where a long asset name is using the full available height until the asset is selected. Then the buttons are superimposed.
Removed unused imports
Removed the center alignment and returned to JTextArea instead of JTextPane
Ungrouped imports
Made sure the buttonPanel is always the same size
( see Cosmetic improvments to the AssetPanelItem #419 )
When asset name is to large, the buttonPanel will be shown on top
Made clicking the AssetPanelItem easier
When clicking an asset, I had the issue that one out of three clicks didn't seem to register. The cause of this was a slight movement of my pointer during the click. Therefore I added the mouseRelease as well, beside the mouseClick, so it registers more actions.
Any feedback/remarks welcome.