Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install instructions don't take package-manager setting into account #40

Closed
canadaduane opened this issue Jan 13, 2022 · 2 comments · Fixed by #42
Closed

Install instructions don't take package-manager setting into account #40

canadaduane opened this issue Jan 13, 2022 · 2 comments · Fixed by #42

Comments

@canadaduane
Copy link
Collaborator

When running chomp without auto-install, it provides warning messages showing how to install the necessary dependencies, e.g.:

Chomp: Some packages are missing. Please run npm install @jspm/generator mkdirp -D

I'm using pnpm and (stupidly) copy/pasted the npm command. Would be nice if it took package-manager into account, i.e.:

Chomp: Some packages are missing. Please run pnpm install @jspm/generator mkdirp -D
@guybedford
Copy link
Owner

Do you feel like making a PR? The template line is here - https://github.com/guybedford/chomp/blob/main/templates/npm.toml#L31. It should just be a substitution like the others. That it's JS in a toml string outputting JSON that will be interpreted as task TOML gets a bit confusing, but makes sense with enough staring :)

@guybedford
Copy link
Owner

guybedford commented Jan 13, 2022

*A string in a shell command on a JSON task output from a JS function that's a string in a TOML file :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants