New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internationalized domain name (IDN) support #2286
Conversation
The build will be green when #2278 is merged. Other tests are OK. |
Although this PR is self-contained, guzzle/psr7#269 makes IDN support overall better. |
@alexeyshockov Thanks! Can you please rebase your branch? |
76456d6
to
0570984
Compare
@sagikazarmark, done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see support for these coming.
0570984
to
5d5a2ba
Compare
@sagikazarmark, could you take a look also at this for the next release? |
bce3ee9
to
7078333
Compare
Yeah, it's on my list, thanks. I recall a related PR in the psr7 package. Is it a dependency of this PR? Do we have to raise the minimum version? |
No, the PR to PSR7 is not a dependency, but an addition (very convenient, though, because without it Guzzle will struggle with locales, that's why hardcoded it to
Minimum version of PHP stays the same (IDN support is enabled only when |
I meant PSR7 package version, but it's not necessary then. |
Yeah, I mixed things with PSR7 package a bit, will prepare a separate PR to |
I think this looks good. Could you add a test where you use base_uri? |
7078333
to
ed0b4ab
Compare
If you rebase this on master and then add a test where you use an internationalized domain in |
8489090
to
3c4f6fc
Compare
@Nyholm, done |
3c4f6fc
to
87a1ef0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
This PR introduces IDN support on client's level, so all the handlers will work with the ASCII version of the IDN with no need for additional conversion.
Also fixes #2285.