Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalized domain name (IDN) support #2286

Merged
merged 5 commits into from Dec 7, 2019

Conversation

alexeyshockov
Copy link
Collaborator

@alexeyshockov alexeyshockov commented Apr 14, 2019

This PR introduces IDN support on client's level, so all the handlers will work with the ASCII version of the IDN with no need for additional conversion.

Also fixes #2285.

@alexeyshockov
Copy link
Collaborator Author

The build will be green when #2278 is merged. Other tests are OK.

@alexeyshockov
Copy link
Collaborator Author

Although this PR is self-contained, guzzle/psr7#269 makes IDN support overall better.

@sagikazarmark
Copy link
Member

@alexeyshockov Thanks! Can you please rebase your branch?

@alexeyshockov
Copy link
Collaborator Author

@sagikazarmark, done

Copy link

@atymic atymic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see support for these coming.

src/RequestOptions.php Outdated Show resolved Hide resolved
tests/bootstrap.php Show resolved Hide resolved
@alexeyshockov
Copy link
Collaborator Author

@sagikazarmark, could you take a look also at this for the next release?

@sagikazarmark
Copy link
Member

Yeah, it's on my list, thanks. I recall a related PR in the psr7 package. Is it a dependency of this PR? Do we have to raise the minimum version?

@sagikazarmark sagikazarmark added this to the 6.4.0 milestone Oct 14, 2019
@alexeyshockov
Copy link
Collaborator Author

Is it a dependency of this PR?

No, the PR to PSR7 is not a dependency, but an addition (very convenient, though, because without it Guzzle will struggle with locales, that's why hardcoded it to 'C' in the tests).

Do we have to raise the minimum version?

Minimum version of PHP stays the same (IDN support is enabled only when intl extension is available).

@sagikazarmark
Copy link
Member

Minimum version of PHP stays the same (IDN support is enabled only when intl extension is available).

I meant PSR7 package version, but it's not necessary then.

@alexeyshockov
Copy link
Collaborator Author

Yeah, I mixed things with PSR7 package a bit, will prepare a separate PR to 1.x branch

@Nyholm Nyholm modified the milestones: 6.4.0, 6.5.0 Oct 18, 2019
@Nyholm
Copy link
Member

Nyholm commented Oct 20, 2019

I think this looks good. Could you add a test where you use base_uri?

@Nyholm
Copy link
Member

Nyholm commented Oct 23, 2019

If you rebase this on master and then add a test where you use an internationalized domain in base_uri, then I would be happy to merge.

@alexeyshockov
Copy link
Collaborator Author

@Nyholm, done

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to cyrillic domain fails
4 participants