league\uri as a PSR's UriInterface implementation

[alexeyshockov]

A proposal to use league\uri package instead of the current Uri implementation. My main goal for this is to get rid of PHP's parse_url() issues with internationalized domain names (see #269 and guzzle/guzzle#2286).

It's a BC break, but has not been released yet, so IMO it's good chance for a change like this.

[Nyholm]

Couldnt we just fix the parse_url issues? Or use https://github.com/thephpleague/uri-parser?

[GrahamCampbell]

Well, is there a point in having two implementations? Seems like s good idea to reuse leagues?

[alexeyshockov]

@Nyholm, league/uri-parser is deprecated, league/uri should be used instead.

As @GrahamCampbell already said, my main idea is to decrease the product scope. UriInterface is already implemented (in league/uri, for example), so why does Guzzle need to maintain it's own implementation? My fix in #297 is a bit hacky and doesn't fix other bug that PHP's parse_uri() contains. And it seems that PHP's parser will stay the same because of backward compatibility.

So if we want to have a better parser for 2.x (hacks around parse_url() don't count), why would we write another one from scratch when league/uri has implemented it already?

[alexeyshockov]

And yes, we can use just a URI parser from league/uri, but why not take the whole URI implementation? Less code to maintain here.

[Tobion]

While I know that PHPs parse_url has broken edge cases, I cannot accept the PR like this. The BC break is far too big. If it's just about replacing parse_url with league/uri parsing, I would consider this. This way the end user would not be affected and the change is a pure internal implementation.

[Nyholm]

I’m also 👎