Locale independent \parse_url() wrapper for UTF-8 strings #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
reviewed
Jun 6, 2019
|
Closing this PR, because master is pointing on 2.x already (and the code was written with 1.x in mind). I will reopen it for |
This was referenced Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\parse_url()breaks UTF-8 domain names (IDN) when used with locales other than "C". This PR introduces a small wrapper around the internal function to make Guzzle locale independent (and those more usable when you work with IDNs).P.S.
For 2.x branch
leageu/uri-parserworths a try, IMO. It's a pure PHP implementation that is compatible with `\parse_url() that works nicely with UTF-8 and is more compatible with the standard.