You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In general, I think it is always ok to stop something not running.
But in this case, it seams worst because I didn't see any bn::music::isPlaying() method, or something like this, so, you can't know if it's possible to stop the music...
.
Edit: Sorry, there is a bn::music::playing(). It's late, I'm probably too tired... Still, I think it's ok to stop something not running. It would avoid a useless test. bn::sound::stop_all() don't raise any error.
If you want or need that behavior (safe music stop), you can write your own music interface that manages bn::music as you want.
The same happens with bn::music_item, for example you could write a class that inherits bn::music_item with those extra methods, if you think they make sense.
Yes, it's what I did. I only open this issue because I didn't see any method to check is a music was playing (and I checked twice the doc). And of course, right after doing that, I saw the playing function (I really don't know how I missing that). I was thinking you might be interested to have feedback on the api so I didn't closed the issue.
In general, I think it is always ok to stop something not running.
But in this case, it seams worst because I didn't see any
bn::music::isPlaying()
method, or something like this, so, you can't know if it's possible to stop the music....
Edit: Sorry, there is a
bn::music::playing()
. It's late, I'm probably too tired... Still, I think it's ok to stop something not running. It would avoid a useless test.bn::sound::stop_all()
don't raise any error.I'm not sure but I think those methods:
should be available in
bn::music_item
also ??The text was updated successfully, but these errors were encountered: