-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] track sync --beginning #33
Comments
Thank you for your feedback and your PR. Wouldn't it be better to add an option to the update command to perform the 3 commands? update --sync
track sync --delete
update Is the goal being able to use the "Follow" button on the JNC to manage tracked series? (instead of doing But the PR is simple enough so I am fine with adding it as is. Let me know. |
You're right. It would be better to do it that way. I was looking through the code a bit, and saw that it would be very easy to do it this way. The way I'm using this is that I've got a schedule task running every night where I sync all the new follows, remove any that has been unfollowed, and download all the new parts. Still think this change kinda make sense for the track command? And then change the update command to be able to do sync and delete as part of the update? |
I made a quick PR that make it possible to add --delete and --beginning with the update command also. --beginning is meaningless though since other code force start from beginning, so might want to remove it, or change the code. changing the code whould be changing functionality though, which might not be good. could also change it back so --beginning is removed, and update --sync is the way to add tracked from the start. |
Yes. I think that would be the way to go. I prefer leaving the other options as is and add a single option to the update command that would do the 3 commands you propose. I don't know if I will use your PR but I will make the change in the next few days. |
Sounds good with me. I don't feel strongly about keeping it the way I did it. Thanks for all your time. |
I have made a new release with the features you added (--whole-final and --beginning). Thank you for your contribution. |
Add --beginning flag to add newly followed tracks from the first part.
As it is now I do 3 commands each update
update --sync
update track sync --delete
update
with this change I would only need to do
update track sync --delete --beginning
update
Got a PR if it's ok. Very simple, only add flag and hook into the current check if no parts available yet.
The text was updated successfully, but these errors were encountered: