Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] track sync --beginning #33

Closed
pajoh opened this issue May 28, 2023 · 6 comments
Closed

[Feature Request] track sync --beginning #33

pajoh opened this issue May 28, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@pajoh
Copy link

pajoh commented May 28, 2023

Add --beginning flag to add newly followed tracks from the first part.
As it is now I do 3 commands each update
update --sync
update track sync --delete
update

with this change I would only need to do
update track sync --delete --beginning
update

Got a PR if it's ok. Very simple, only add flag and hook into the current check if no parts available yet.

@gvellut
Copy link
Owner

gvellut commented May 28, 2023

Thank you for your feedback and your PR.

Wouldn't it be better to add an option to the update command to perform the 3 commands?

update --sync
track sync --delete
update

Is the goal being able to use the "Follow" button on the JNC to manage tracked series? (instead of doing track <URL>). I am asking because, at some point, I wanted to make a simple GUI that would have had a single button "Update" and leave the management of followed series to the JNC website (using the "Follow" button). And the 3 commands above were those that would have been launched when clicking on that button. I didn't follow through with that GUI nor implemented the functionality in the end but I had named it "sync-plus" ie adding a "--sync-plus" parameter to update.

But the PR is simple enough so I am fine with adding it as is. Let me know.

@pajoh
Copy link
Author

pajoh commented May 28, 2023

You're right. It would be better to do it that way. I was looking through the code a bit, and saw that it would be very easy to do it this way.

The way I'm using this is that I've got a schedule task running every night where I sync all the new follows, remove any that has been unfollowed, and download all the new parts.
This way I'm pretty much using JNC's website as the GUI for this program.

Still think this change kinda make sense for the track command? And then change the update command to be able to do sync and delete as part of the update?

@pajoh
Copy link
Author

pajoh commented May 28, 2023

I made a quick PR that make it possible to add --delete and --beginning with the update command also. --beginning is meaningless though since other code force start from beginning, so might want to remove it, or change the code. changing the code whould be changing functionality though, which might not be good.

could also change it back so --beginning is removed, and update --sync is the way to add tracked from the start.

@gvellut gvellut added the enhancement New feature or request label May 30, 2023
@gvellut
Copy link
Owner

gvellut commented May 30, 2023

Still think this change kinda make sense for the track command? And then change the update command to be able to do sync and delete as part of the update?

Yes. I think that would be the way to go. I prefer leaving the other options as is and add a single option to the update command that would do the 3 commands you propose. I don't know if I will use your PR but I will make the change in the next few days.

@pajoh
Copy link
Author

pajoh commented May 31, 2023

Sounds good with me. I don't feel strongly about keeping it the way I did it.
If there's something I can do let me know, otherwise I'll just wait paitently for your update.

Thanks for all your time.

@gvellut
Copy link
Owner

gvellut commented Jun 13, 2023

I have made a new release with the features you added (--whole-final and --beginning). Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants