Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the way log data is saved #44

Closed
3 of 4 tasks
Sejsel opened this issue Jan 6, 2020 · 1 comment
Closed
3 of 4 tasks

Rework the way log data is saved #44

Sejsel opened this issue Jan 6, 2020 · 1 comment
Labels
enhancement New feature or request refactoring Code can be improved

Comments

@Sejsel
Copy link
Member

Sejsel commented Jan 6, 2020

It has to be possible to provide an option to parse predefined logs when updating (e.g. when a success detection is fixed). We also want to make it possible to change languages of log names in dynamically (currently the name is saved).

  • Store a version of the log data format
  • Version of the manager as of parsing time needs to be saved for each log.
  • Store the Encounter and not the name for each log
  • I am currently forgetting something important

It would be nice to add support for storing optional extra data (calculated at the cost of processing time), or at the very least, make it simple to import saved data to allow that in the future (it might be already).

@Sejsel Sejsel added enhancement New feature or request refactoring Code can be improved labels Jan 6, 2020
@Sejsel Sejsel added this to the Log Manager v0.7 milestone Jan 6, 2020
@Sejsel
Copy link
Member Author

Sejsel commented Feb 25, 2020

Implemented in 02f1e05...9967df7.

@Sejsel Sejsel closed this as completed Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring Code can be improved
Projects
None yet
Development

No branches or pull requests

1 participant