Enabling output of dof from autochisq.values() #4752
Conversation
| ( | ||
| ifo_out_vals['auto_chisq'], | ||
| ifo_out_vals['auto_chisq_dof'], | ||
| ) = autochisq.values( |
There was a problem hiding this comment.
Does this work? I'd expect ifo_out_vals['auto_chisq_dof'] to be a single integer, and ifo_out_vals['auto_chisq'] to be an array. Would this cause issues later if this isn't handled correctly?
... While I'm happy for this function to return the DOF parameter for consistency, I'm not sure it's going to be useful for much (assuming the auto_chisq value is already divided by DOF).
There was a problem hiding this comment.
Yes, it works, no there are no issues because the numpy.repeat call in this case is here, which replicates this other line.
Let me know if you want me to move the calls from these two lines to pycbc/vetoes/autochisq.py in the spirit of make things even across the chi-squares. I have to push another commit in any event because I noticed that this description is incomplete.
There was a problem hiding this comment.
No, if there is a numpy.repeat then this is not a concern.
|
Thank you! |
Unlike other chi-squared values methods, autochisq.values() computes the number of degrees of freedom but does not return it. This PR makes the situation even across the values methods of the various chi-squares.
This change affects: PyGRB (autochi-square plots can now be generated) and
pycbc_inspiral(coincident searches) but the degrees of freedom are dumped to_so nothing meaningful is modified.Testing performed
A full PyGRB workflow with the generation of autochi-square plots was successfully carried out.