Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steady_state_perlen is ingored for steady_state=True (and only used when steady_start=True) #228

Closed
rubencalje opened this issue Aug 24, 2023 · 2 comments · Fixed by #257
Assignees
Labels
bug Something isn't working

Comments

@rubencalje
Copy link
Collaborator

No description provided.

@dbrakenhoff dbrakenhoff self-assigned this Aug 24, 2023
@dbrakenhoff dbrakenhoff added the bug Something isn't working label Aug 25, 2023
@dbrakenhoff
Copy link
Collaborator

This is fixed in the new nlmod.time.set_ds_time(). We now expect the user to provide the time indices at the end of each stress period. See #257.

@dbrakenhoff dbrakenhoff linked a pull request Aug 28, 2023 that will close this issue
@rubencalje
Copy link
Collaborator Author

I will remove this issue (which I created), as steady_state_perlen does not exist as a parameter in nlmod.time.set_ds_time. The parameter that does exist is steady_start_perlen, which determines the length of the first steady-state stress period when steady_start is used. On second thought it is not strange that the parameter is ignored for an entirely steady-state run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants