Added more formatting attributes for -D #471
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was noticing that you can now use --color/-D to set colors, which is so much nicer than the LESS_TERMCAP_ environment variables. However, there was something missing; with the environment variables, I make blinking text bold instead of blinking, but that didn't seem to be possible with -D, so I added it.
The new symbols * and _ for bold and underline are based on common convention/Markdown. ~ for standout comes from the C not bitwise operator (since terminals tend to reverse the colors in standout mode; I originally made it \ but I thought that might get confused with an escape character; some Markdown dialects use ~ for strikethrough, so ~ might not be the best choice either). & for blink is arbitrary.
This PR however does have one limitation: It still only works for lowercase letters. It's still not possible to make the prompt bold, for example. I might look into why later.