You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 11, 2022. It is now read-only.
I'm totally ok with renaming asJsArray() to create(). It sounds more GWT-ish naming. ;)
I don't know about the class name, maybe we could also look at it the other way around and rename Array to JsArray. I don't know... Anyway, I agree with you, it needs to be consistent.
IMHO, most of the code in Array, JsArrays and in the array package is not directly related to D3. It's mostly standard Javascript API. Maybe we should think about creating a dedicated project for this stuff. What do you think ?
But I agree with you: JsArray sounds better than Array since it is pure Javascript (e.g gwtquery adopts the same naming convention, see gwtquery.googlecode.com/svn/trunk/gwtquery-core/javadoc/com/google/gwt/query/client/js/JsObjectArray.html).
By the way, I think we should change the return type of the methods JsArrays.asJsArray() to return gwtd3 Array rather than GWT built in JsArray.
Keep the same package, but just rename JsArrays to Arrays, for consistency with the Array class.
Also; rename the asJsArray methods into create() methods.
The text was updated successfully, but these errors were encountered: