Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"TIMEZONE" should be "TIME ZONE" in type "TIMESTAMP WITH TIMEZONE" #411

Closed
basil-bourque opened this issue Dec 13, 2016 · 4 comments
Closed

Comments

@basil-bourque
Copy link

The data type of TIMESTAMP WITH TIMEZONE is misspelled, where TIMEZONE should be spelled as two words TIME ZONE.

http://h2database.com/html/datatypes.html#timestamp_with_timezone_type

  • TIMESTAMP WITH TIMEZONE (wrong)
  • TIMESTAMP WITH TIME ZONE (right)

According to:

  • SQL standard data types as listed in Wikipedia.
  • Postgres documentation listing Date/Time types.
  • CD 9075-1:200x(E) standard draft, in the Framework document, section 4.4.3.5 Datetime types: “TIMESTAMP and TIME may also be specified as being WITH TIME ZONE…”.

I suggest:

  • Adding support for correct spelling, and
  • Deprecating the incorrect spelling with plans for eventual removal.

Seems fair enough, especially as the class doc warns this type is currently experimental and not finalized.

@grandinj
Copy link
Contributor

Patches are more than welcome :-)

@lukaseder
Copy link
Contributor

From the commit 4f50464 I understand that the TIMEZONE literal will still be parsed, at least for a while. My questions:

  1. Is this correct?
  2. Do you have any plans when you'll remove support for the TIMEZONE literal?

@grandinj
Copy link
Contributor

  1. Yes
  2. Probably never. In theory I'd give it a year but by then I'll probably have forgotten and it's literally 2 extra lines of code.

@lukaseder
Copy link
Contributor

OK, great, thanks for the quick reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants