-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test coverage for JDK 17 #3718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
h2/src/tools/org/h2/build/Build.java
Outdated
String version = System.getProperty("java.specification.version"); | ||
if (version.startsWith("1.")) { | ||
version = version.substring(2); | ||
} | ||
return Integer.parseInt(version) >= 15; // Nashorn was removed in Java 15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use getJavaVersion()
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I didn't see that! Done in 687cc0f.
Builds on Java 11 and Java 17 were cancelled after failure on Java 8. Did it happen due to changes in |
Please, add |
Done in 1b2d113. |
Since we'd like to use H2 on JDK 17, it would be great if it would be officially tested on it. Thus, this PR adds another CI build for JDK 17 (in addition to the ones for JDK 8 and 11). In order to work with JDK 17 bytecode, the test dependency on ASM was updated to 9.4. Since the Nashorn Javascript engine was removed in JDK 15, it's added as another test dependency when the build is running on 15 or later.