Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make setup fails on OSX #112

Closed
fazpu opened this issue Dec 27, 2022 · 1 comment
Closed

make setup fails on OSX #112

fazpu opened this issue Dec 27, 2022 · 1 comment
Assignees
Labels
area/packaging Related to packaging type/bug Doesn't work as expected
Milestone

Comments

@fazpu
Copy link
Contributor

fazpu commented Dec 27, 2022

Describe the bug
https://github.com/h2oai/nitro/blob/598856e7b24dc159ec1eb8a4e424bf9e377f5031/CONTRIBUTING.md

make setup fails with:

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [8 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/Users/jiripuc/code/github/nitro/py/web/setup.py", line 30, in <module>
          version=get_version("h2o_nitro_web"),
        File "/Users/jiripuc/code/github/nitro/py/web/setup.py", line 12, in get_version
          init_py = open(path, "r", encoding="utf8").read()
      FileNotFoundError: [Errno 2] No such file or directory: 'h2o_nitro_web/version.py'
      [end of output]

The source of the problem is that make version gives:

make: `version' is up to date.

Environment (please complete the following information):

  • Nitro version: 0.19.0

Additional context
Add any other context about the problem here.

@fazpu fazpu added the type/bug Doesn't work as expected label Dec 27, 2022
@lo5
Copy link
Member

lo5 commented Jan 4, 2023

@fazpu Thanks for reporting.

Looks like make sees /VERSION on OSX (case-insensitive).

On Linux:

$ make version
echo "__version__ = \"0.19.0\"" > py/pkg/h2o_nitro/version.py
echo "__version__ = \"0.19.0\"" > py/web/h2o_nitro_web/version.py

$ make VERSION
make: Nothing to be done for 'VERSION'.

I'll rename the make task.

@lo5 lo5 added this to the 0.20 milestone Jan 4, 2023
@lo5 lo5 changed the title make setup fails make setup fails on OSX Jan 4, 2023
@lo5 lo5 added the area/packaging Related to packaging label Jan 4, 2023
@lo5 lo5 closed this as completed in 45b2d67 Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packaging Related to packaging type/bug Doesn't work as expected
Projects
None yet
Development

No branches or pull requests

2 participants