Skip to content
This repository has been archived by the owner on Nov 23, 2018. It is now read-only.

fix jpegtran metadata stripping #152

Merged
merged 1 commit into from
Mar 11, 2013
Merged

fix jpegtran metadata stripping #152

merged 1 commit into from
Mar 11, 2013

Conversation

rrelmy
Copy link
Contributor

@rrelmy rrelmy commented Mar 9, 2013

The option «-copy» of jpegtran is used in the wrong way.

If stripping metadata is turned on the argument gets the value «all» otherwise «none».
Jpegtran copies the metadata if «all», «none» does omit them.

I renamed the variable «strip-meta-tags» to «retain-meta-tags», that should be more clear

$ jpegtran --help
usage: jpegtran [switches] [inputfile]
Switches (names may be abbreviated):
  -copy none     Copy no extra markers from source file
  -copy comments Copy only comment markers (default)
  -copy all      Copy all extra markers

roblarsen added a commit that referenced this pull request Mar 11, 2013
@roblarsen
Merge pull request #152 from rrelmy/jpegtran-metadata-stripping
ce02602 
fix jpegtran metadata stripping
@roblarsen roblarsen merged commit ce02602 into h5bp:master Mar 11, 2013
@roblarsen
Copy link
Member

Thanks!

@rrelmy rrelmy deleted the jpegtran-metadata-stripping branch March 11, 2013 14:53
@roblarsen roblarsen mentioned this pull request Jul 11, 2013
Open
@roblarsen
Copy link
Member

Open for testing
https://github.com/h5bp/ant-build-script/tree/new-image-optimization

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rrelmy @roblarsen