Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_conv.pyx is mostly untested ... #1405

Open
kif opened this issue Oct 15, 2019 · 1 comment
Open

_conv.pyx is mostly untested ... #1405

kif opened this issue Oct 15, 2019 · 1 comment
Labels
enhancement pull-request-welcome

Comments

@kif
Copy link
Contributor

kif commented Oct 15, 2019

Hi,

While refactoring the code in order to use the cython include instead of the one from h5py, I found most of the conversion functions are untested. I will mark them as such in a comment.
kif added a commit to kif/h5py that referenced this issue Oct 15, 2019
@kif
Added comments for untested function
e13255e 
Replace the comment with "raise RuntimeError()" does
not prevent the tests from passing.
Related to issue h5py#1405
kif added a commit to kif/h5py that referenced this issue Oct 15, 2019
@kif
Added comments for untested function
4209de3 
Replace the comment with "raise RuntimeError()" does
not prevent the tests from passing.
Related to issue h5py#1405
@kif kif mentioned this issue Oct 15, 2019
Merged
@takluyver
Copy link
Member

Coverage measurement for Cython (@aragilar's WIP PR #1004) would be really valuable to see what the tests exercise.

@t20100 t20100 mentioned this issue Oct 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement pull-request-welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@takluyver @kif @aragilar